Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp
diff --git a/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp b/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp
index b4fbfa45f0dd6907e76f0d24b90dfaabe1ce53a5..1ebe70cccea9d159214b5c6b9d57a3e3cbfe473d 100644
--- a/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp
+++ b/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp
@@ -158,7 +158,7 @@ void V8CustomElementLifecycleCallbacks::created(Element* element)
element->setCustomElementState(Element::Upgraded);
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValue())
return;
ScriptState::Scope scope(m_scriptState.get());
v8::Isolate* isolate = m_scriptState->isolate();
@@ -208,7 +208,7 @@ void V8CustomElementLifecycleCallbacks::attributeChanged(Element* element, const
if (!executionContext() || executionContext()->activeDOMObjectsAreStopped())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValue())
return;
ScriptState::Scope scope(m_scriptState.get());
v8::Isolate* isolate = m_scriptState->isolate();
@@ -241,7 +241,7 @@ void V8CustomElementLifecycleCallbacks::call(const ScopedPersistent<v8::Function
if (!executionContext() || executionContext()->activeDOMObjectsAreStopped())
return;
- if (m_scriptState->contextIsEmpty())
+ if (m_scriptState->contextIsValue())
return;
ScriptState::Scope scope(m_scriptState.get());
v8::Isolate* isolate = m_scriptState->isolate();

Powered by Google App Engine
This is Rietveld 408576698