Source/bindings/core/v8/V8EventListenerList.cpp - Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8EventListenerList.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptState.h ('K') | « Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp ('k') | Source/bindings/core/v8/V8MutationCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/V8EventListenerList.cpp

diff --git a/Source/bindings/core/v8/V8EventListenerList.cpp b/Source/bindings/core/v8/V8EventListenerList.cpp

index e13f9607d8f66b76c04b8e4a4a1ed1c6f831e5da..07497a174eccf1c4a0e81e1a4dd5d740dc4c3a64 100644

--- a/Source/bindings/core/v8/V8EventListenerList.cpp

+++ b/Source/bindings/core/v8/V8EventListenerList.cpp

@@ -39,7 +39,7 @@ namespace blink {

PassRefPtr<EventListener> V8EventListenerList::getEventListener(ScriptState* scriptState, v8::Local<v8::Value> value, bool isAttribute, ListenerLookupType lookup)

{

- ASSERT(!scriptState->contextIsEmpty());

+ ASSERT(!scriptState->contextIsValue());

if (lookup == ListenerFindOnly) {

// Used by EventTarget::removeEventListener, specifically

// EventTargetV8Internal::removeEventListenerMethod