Source/bindings/core/v8/V8AbstractEventListener.cpp - Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8AbstractEventListener.cpp

Issue 538933002: ScriptState::contextIsEmpty shouldn't return true for a context whose global object is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptState.h ('K') | « Source/bindings/core/v8/ScriptValue.cpp ('k') | Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/V8AbstractEventListener.cpp

diff --git a/Source/bindings/core/v8/V8AbstractEventListener.cpp b/Source/bindings/core/v8/V8AbstractEventListener.cpp

index 6e8487ee27cbc3cfbfe70442c5cb9c58ce8e8060..c9ee784d79285ed4d610360afe99705741860339 100644

--- a/Source/bindings/core/v8/V8AbstractEventListener.cpp

+++ b/Source/bindings/core/v8/V8AbstractEventListener.cpp

@@ -75,7 +75,7 @@ V8AbstractEventListener::~V8AbstractEventListener()

void V8AbstractEventListener::handleEvent(ExecutionContext*, Event* event)

{

- if (scriptState()->contextIsEmpty())

+ if (scriptState()->contextIsValue())

return;

if (!scriptState()->executionContext())

return;

@@ -110,7 +110,7 @@ void V8AbstractEventListener::invokeEventHandler(Event* event, v8::Local<v8::Val

if (jsEvent.IsEmpty())

return;

- ASSERT(!scriptState()->contextIsEmpty());

+ ASSERT(!scriptState()->contextIsValue());

v8::Local<v8::Value> returnValue;

{

// Catch exceptions thrown in the event handler so they do not propagate to javascript code that caused the event to fire.