Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Issue 538403003: Automatically wait for elements to be displayed in the password manager python tests (Closed)

Created:
6 years, 3 months ago by rchtara
Modified:
6 years, 3 months ago
Reviewers:
vabr (Chromium), battre
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Automatically wait for elements to be displayed in the password manager python tests. Automatically wait for DOM element visibly at the beginning of actions (click, submit) in the password manager python tests. BUG=411325 Committed: https://crrev.com/db1f2fe9dd048496f1ce3689ec2fd55f62eed88a Cr-Commit-Position: refs/heads/master@{#293557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M components/test/data/password_manager/tests.py View 8 chunks +0 lines, -10 lines 0 comments Download
M components/test/data/password_manager/websitetest.py View 6 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rchtara
Hi Could you please review this cl? Thanks a lot Riadh
6 years, 3 months ago (2014-09-05 16:00:03 UTC) #2
vabr (Chromium)
LGTM. Thanks! Vaclav
6 years, 3 months ago (2014-09-05 16:07:47 UTC) #3
rchtara
Thanks a lot for the review Riadh
6 years, 3 months ago (2014-09-05 16:14:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rchtara@chromium.org/538403003/1
6 years, 3 months ago (2014-09-05 16:15:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 22384c877fbd67a56b9b4da973d184ee76ca51a7
6 years, 3 months ago (2014-09-05 18:15:05 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db1f2fe9dd048496f1ce3689ec2fd55f62eed88a
Cr-Commit-Position: refs/heads/master@{#293557}

Powered by Google App Engine
This is Rietveld 408576698