Automatically wait for elements to be displayed in the password manager python tests

components/test/data/password_manager/websitetest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """WebsiteTest testing class."""
 
 import logging
 import sys
 import time
 
@@ skipping 65 matching lines @@
 
   # Mouse/Keyboard actions.
 
   def Click(self, selector):
     """Clicks on an element.
 
     Args:
       selector: The element CSS selector.
     """
     logging.info("action: Click %s" % selector)
+    self.WaitUntilDisplayed(selector)
     element = self.driver.find_element_by_css_selector(selector)
     element.click()
 
   def ClickIfClickable(self, selector):
     """Clicks on an element if it's clickable: If it doesn't exist in the DOM,
     it's covered by another element or it's out viewing area, nothing is
     done and False is returned. Otherwise, even if the element is 100%
     transparent, the element is going to receive a click and a True is
     returned.
 
     Args:
       selector: The element CSS selector.
 
     Returns:
       True if the click happens.
       False otherwise.
     """
     logging.info("action: ClickIfVisible %s" % selector)
+    self.WaitUntilDisplayed(selector)
     try:
       element = self.driver.find_element_by_css_selector(selector)
       element.click()
       return True
     except Exception:
       return False
 
   def GoTo(self, url):
     """Navigates the main frame to the |url|.
 
     Args:
       url: The URL.
     """
     logging.info("action: GoTo %s" % self.name)
     if self.environment.first_go_to:
       self.environment.OpenTabAndGoToInternals(url)
       self.environment.first_go_to = False
     else:
       self.driver.get(url)
 
   def HoverOver(self, selector):
     """Hovers over an element.
 
     Args:
       selector: The element CSS selector.
     """
     logging.info("action: Hover %s" % selector)
+    self.WaitUntilDisplayed(selector)
     element = self.driver.find_element_by_css_selector(selector)
     hover = ActionChains(self.driver).move_to_element(element)
     hover.perform()
 
   def SendEnterTo(self, selector):
     """Sends an enter key to an element.
 
     Args:
       selector: The element CSS selector.
     """
@@ skipping 59 matching lines @@
     Then, fills the input with the Website password.
 
     Args:
       selector: The password input CSS selector.
 
     Raises:
       Exception: An exception is raised if the DOM value of the password is
           different than the one we expected.
     """
     logging.info("action: FillPasswordInto %s" % selector)
-
+    self.WaitUntilDisplayed(selector)
     password_element = self.driver.find_element_by_css_selector(selector)
     # Chrome protects the password inputs and doesn't fill them until
     # the user interacts with the page. To be sure that such thing has
     # happened we perform |Keys.CONTROL| keypress.
     action_chains = ActionChains(self.driver)
     action_chains.key_down(Keys.CONTROL).key_up(Keys.CONTROL).perform()
     if self.mode == self.Mode.AUTOFILLED:
       autofilled_password = password_element.get_attribute("value")
       if autofilled_password != self.password:
         raise Exception("Error: autofilled password is different from the one "
@@ skipping 17 matching lines @@
     username.
 
     Args:
       selector: The username input CSS selector.
 
     Raises:
       Exception: An exception is raised if the DOM value of the username is
           different that the one we expected.
     """
     logging.info("action: FillUsernameInto %s" % selector)
+    self.WaitUntilDisplayed(selector)
     username_element = self.driver.find_element_by_css_selector(selector)
 
     if (self.mode == self.Mode.AUTOFILLED and not self.username_not_auto):
       if not (username_element.get_attribute("value") == self.username):
         raise Exception("Error: autofilled username is different form the one "
                         "we just saved for the following website : %s \n" %
                         self.name)
     else:
       username_element.clear()
       username_element.send_keys(self.username)
 
   def Submit(self, selector):
     """Finds an element using CSS Selector and calls its submit() handler.
 
     Args:
       selector: The input CSS selector.
     """
     logging.info("action: Submit %s" % selector)
+    self.WaitUntilDisplayed(selector)
     element = self.driver.find_element_by_css_selector(selector)
     element.submit()
 
   # Login/Logout Methods
 
   def Login(self):
     """Login Method. Has to be overloaded by the WebsiteTest test."""
     raise NotImplementedError("Login is not implemented.")
 
   def LoginWhenAutofilled(self):
@@ skipping 115 matching lines @@
 
     self.LoginWhenNotAutofilled()
     self.Wait(2)
     self.environment.SwitchToInternals()
     self.environment.CheckForNewMessage(
         environment.MESSAGE_ASK,
         True,
         "Error: password manager hasn't detected a successful login for the "
         "following website : %s \n" % self.name)
     self.environment.SwitchFromInternals()