Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: components/test/data/password_manager/tests.py

Issue 538403003: Automatically wait for elements to be displayed in the password manager python tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/test/data/password_manager/websitetest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test/data/password_manager/tests.py
diff --git a/components/test/data/password_manager/tests.py b/components/test/data/password_manager/tests.py
index 90fd2408bac5d59b3d74297d542d5d1131f3da5a..8bde955255f01555099b4083ce16755084318e61 100644
--- a/components/test/data/password_manager/tests.py
+++ b/components/test/data/password_manager/tests.py
@@ -40,7 +40,6 @@ class Google(WebsiteTest):
def Login(self):
self.GoTo("https://accounts.google.com/ServiceLogin?sacu=1&continue=")
- self.WaitUntilDisplayed("#Email")
self.FillUsernameInto("#Email")
self.FillPasswordInto("#Passwd")
self.Submit("#Passwd")
@@ -106,7 +105,6 @@ class Twitter(WebsiteTest):
def Login(self):
self.GoTo("https:///twitter.com")
- self.WaitUntilDisplayed("#signin-email")
self.FillUsernameInto("#signin-email")
self.FillPasswordInto("#signin-password")
self.Submit("#signin-password")
@@ -173,7 +171,6 @@ class Baidu(WebsiteTest):
def Login(self):
self.GoTo("https://passport.baidu.com")
- self.WaitUntilDisplayed("[name='userName']")
self.FillUsernameInto("[name='userName']")
self.FillPasswordInto("[name='password']")
self.Submit("[name='password']")
@@ -202,7 +199,6 @@ class Ebay(WebsiteTest):
def Login(self):
self.GoTo("https://signin.ebay.com/")
- self.WaitUntilDisplayed("[name='userid']")
self.FillUsernameInto("[name='userid']")
self.FillPasswordInto("[name='pass']")
self.Submit("[name='pass']")
@@ -219,7 +215,6 @@ class Espn(WebsiteTest):
frame = self.driver.find_element_by_css_selector("#cboxLoadedContent "
"iframe")
self.driver.switch_to_frame(frame)
- self.WaitUntilDisplayed("#username")
self.FillUsernameInto("#username")
self.FillPasswordInto("#password")
while self.IsDisplayed("#password"):
@@ -232,7 +227,6 @@ class Live(WebsiteTest):
def Login(self):
self.GoTo("https://login.live.com")
- self.WaitUntilDisplayed("[name='login']")
self.FillUsernameInto("[name='login']")
self.FillPasswordInto("[name='passwd']")
self.Submit("[name='passwd']")
@@ -243,9 +237,7 @@ class One63(WebsiteTest):
def Login(self):
self.GoTo("http://www.163.com")
- self.WaitUntilDisplayed("#js_N_navHighlight")
self.HoverOver("#js_N_navHighlight")
- self.WaitUntilDisplayed("#js_loginframe_username")
self.FillUsernameInto("#js_loginframe_username")
self.FillPasswordInto(".ntes-loginframe-label-ipt[type='password']")
self.Click(".ntes-loginframe-btn")
@@ -256,9 +248,7 @@ class Vube(WebsiteTest):
def Login(self):
self.GoTo("https://vube.com")
- self.WaitUntilDisplayed("[vube-login='']")
self.Click("[vube-login='']")
- self.WaitUntilDisplayed("[ng-model='login.user']")
self.FillUsernameInto("[ng-model='login.user']")
self.FillPasswordInto("[ng-model='login.pass']")
while (self.IsDisplayed("[ng-model='login.pass']")
« no previous file with comments | « no previous file | components/test/data/password_manager/websitetest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698