build/secondary/third_party/libsrtp/BUILD.gn - Issue 538333002: gn/linux: warnings as errors, turn on Wextra

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/third_party/libsrtp/BUILD.gn

Issue 538333002: gn/linux: warnings as errors, turn on Wextra (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/third_party/libsrtp/BUILD.gn

diff --git a/build/secondary/third_party/libsrtp/BUILD.gn b/build/secondary/third_party/libsrtp/BUILD.gn

index 8787beb53c143a6699ae52a142871f6591b879a3..cfcae79af3098b6f3763ac79849c898afc6015e7 100644

--- a/build/secondary/third_party/libsrtp/BUILD.gn

+++ b/build/secondary/third_party/libsrtp/BUILD.gn

@@ -212,6 +212,9 @@ if (use_system_libsrtp) {

if (is_android) {

defines = [ "HAVE_SYS_SOCKET_H" ]

}

+ if (is_clang) {

+ cflags = [ "-Wno-implicit-function-declaration" ]

Nico 2014/09/08 21:00:23 Hm, gyp doesn't seem to need this.

scottmg 2014/09/08 21:05:05 Hmm, I just tried again to quote an error... and n

+ }

}

executable("srtp_test_cipher_driver") {