build/secondary/third_party/icu/BUILD.gn - Issue 538333002: gn/linux: warnings as errors, turn on Wextra

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/third_party/icu/BUILD.gn

Issue 538333002: gn/linux: warnings as errors, turn on Wextra (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/third_party/icu/BUILD.gn

diff --git a/build/secondary/third_party/icu/BUILD.gn b/build/secondary/third_party/icu/BUILD.gn

index 4f7f0888634638e6ed6a1b0c710514ca7ee03388..ffeabde8c0111824077c65d246f62675fc358b22 100644

--- a/build/secondary/third_party/icu/BUILD.gn

+++ b/build/secondary/third_party/icu/BUILD.gn

@@ -266,6 +266,8 @@ component("icui18n") {

cflags = [

"-Wno-header-hygiene",

+ # ICU uses its own deprecated functions.

+ "-Wno-deprecated-declarations",

# Looks like a real issue, see http://crbug.com/114660

"-Wno-return-type-c-linkage",

]