gn/linux: warnings as errors, turn on Wextra

build/secondary/third_party/libsrtp/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 declare_args() {
   use_system_libsrtp = false
 }
 
 config("libsrtp_config") {
   defines = [
@@ skipping 130 matching lines @@
       "srtp/crypto/rng/ctr_prng.c",
       "srtp/crypto/rng/prng.c",
       "srtp/crypto/rng/rand_source.c",
     ]
 
     if (is_clang) {
       cflags = [ "-Wno-implicit-function-declaration" ]
     }
   }
 
   # TODO(GYP): A bunch of these tests don't compile (in gyp either). They're

[scottmg, 2014/09/08 21:38:37]

It would seem I already knew this. But apparently it's slightly true on Linux
too.

   # not very broken, so could probably be made to work if it's useful.
   if (!is_win) {
     executable("rdbx_driver") {
       configs -= [ "//build/config/compiler:chromium_code" ]
       configs += [ "//build/config/compiler:no_chromium_code" ]
       deps = [ ":libsrtp" ]
       sources = [
         "srtp/include/getopt_s.h",
         "srtp/test/getopt_s.c",
         "srtp/test/rdbx_driver.c",
@@ skipping 43 matching lines @@
         "srtp/include/rtp.h",
         "srtp/include/srtp.h",
         "srtp/crypto/include/datatypes.h",
         "srtp/test/getopt_s.c",
         "srtp/test/rtp.c",
         "srtp/test/rtpw.c",
       ]
       if (is_android) {
         defines = [ "HAVE_SYS_SOCKET_H" ]
       }
+      if (is_clang) {
+        cflags = [ "-Wno-implicit-function-declaration" ]

[Nico, 2014/09/08 21:00:23]

Hm, gyp doesn't seem to need this.

[scottmg, 2014/09/08 21:05:05]

Hmm, I just tried again to quote an error... and neither does gn (now?). I don't
think I added it for fun, but, uh, will remove anyway.

+      }
     }
 
     executable("srtp_test_cipher_driver") {
       configs -= [ "//build/config/compiler:chromium_code" ]
       configs += [ "//build/config/compiler:no_chromium_code" ]
       deps = [ ":libsrtp" ]
       sources = [
         "srtp/crypto/test/cipher_driver.c",
       ]
     }
@@ skipping 73 matching lines @@
         ":srtp_test_stat_driver",
         ":srtp_test_sha1_driver",
         ":srtp_test_kernel_driver",
         ":srtp_test_aes_calc",
         ":srtp_test_rand_gen",
         ":srtp_test_env",
       ]
     }
   }
 }