Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Side by Side Diff: build/secondary/third_party/icu/BUILD.gn

Issue 538333002: gn/linux: warnings as errors, turn on Wextra (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Tells icu to load an external data file rather than rely on the icudata 6 # Tells icu to load an external data file rather than rely on the icudata
7 # being linked directly into the binary. 7 # being linked directly into the binary.
8 # 8 #
9 # This flag is a bit confusing. As of this writing, icu.gyp set the value to 9 # This flag is a bit confusing. As of this writing, icu.gyp set the value to
10 # 0 but common.gypi sets the value to 1 for most platforms (and the 1 takes 10 # 0 but common.gypi sets the value to 1 for most platforms (and the 1 takes
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 direct_dependent_configs = [ ":icu_config" ] 259 direct_dependent_configs = [ ":icu_config" ]
260 260
261 if (is_clang) { 261 if (is_clang) {
262 # uspoof.h has a U_NAMESPACE_USE macro. That's a bug, 262 # uspoof.h has a U_NAMESPACE_USE macro. That's a bug,
263 # the header should use U_NAMESPACE_BEGIN instead. 263 # the header should use U_NAMESPACE_BEGIN instead.
264 # http://bugs.icu-project.org/trac/ticket/9054 264 # http://bugs.icu-project.org/trac/ticket/9054
265 configs -= [ "//build/config/clang:extra_warnings" ] 265 configs -= [ "//build/config/clang:extra_warnings" ]
266 266
267 cflags = [ 267 cflags = [
268 "-Wno-header-hygiene", 268 "-Wno-header-hygiene",
269 # ICU uses its own deprecated functions.
270 "-Wno-deprecated-declarations",
269 # Looks like a real issue, see http://crbug.com/114660 271 # Looks like a real issue, see http://crbug.com/114660
270 "-Wno-return-type-c-linkage", 272 "-Wno-return-type-c-linkage",
271 ] 273 ]
272 } 274 }
273 } 275 }
274 276
275 component("icuuc") { 277 component("icuuc") {
276 sources = [ 278 sources = [
277 "source/common/appendable.cpp", 279 "source/common/appendable.cpp",
278 "source/common/bmpset.cpp", 280 "source/common/bmpset.cpp",
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
509 sources = [ "mac/icudtl_dat.S" ] 511 sources = [ "mac/icudtl_dat.S" ]
510 } else if (is_android) { 512 } else if (is_android) {
511 sources = [ "android/icudtl_dat.S" ] 513 sources = [ "android/icudtl_dat.S" ]
512 } else { 514 } else {
513 assert(false, "No icu data for this platform") 515 assert(false, "No icu data for this platform")
514 } 516 }
515 defines = [ "U_HIDE_DATA_SYMBOL" ] 517 defines = [ "U_HIDE_DATA_SYMBOL" ]
516 } 518 }
517 } 519 }
518 } 520 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698