Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 537023002: Change ScriptContextTest.GetEffectiveDocumentURL to use FrameLoadWaiter and re-enable the test. (Closed)

Created:
6 years, 3 months ago by Marijn Kruisselbrink
Modified:
6 years, 3 months ago
Reviewers:
jam, dcheng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change ScriptContextTest.GetEffectiveDocumentURL to use FrameLoadWaiter and re-enable the test. FrameLoadWaiter relies on DidFinishLoad, which correctly takes into account sub-frame loads as well, so this should fix the test flakiness. BUG=391894 Committed: https://crrev.com/cbb4b862bb3ad12a1e98c0fd0cd65a01defb5055 Cr-Commit-Position: refs/heads/master@{#293415}

Patch Set 1 #

Patch Set 2 : move and use FrameLoadWaiter #

Patch Set 3 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -75 lines) Patch
M content/content_tests.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/test/frame_load_waiter.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/public/test/frame_load_waiter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
D content/test/frame_load_waiter.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
D content/test/frame_load_waiter.cc View 1 1 chunk +0 lines, -27 lines 0 comments Download
M extensions/renderer/script_context_browsertest.cc View 1 4 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Marijn Kruisselbrink
Needing a content/ OWNER reviewer because this moves FrameLoadWaiter from content/test to content/public/test to make ...
6 years, 3 months ago (2014-09-03 19:52:09 UTC) #2
jam
lgtm
6 years, 3 months ago (2014-09-04 22:25:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/537023002/40001
6 years, 3 months ago (2014-09-04 22:43:43 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 6a7368c7dff004b2525187e5b5824f16f69a0cb3
6 years, 3 months ago (2014-09-05 03:09:32 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:05 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cbb4b862bb3ad12a1e98c0fd0cd65a01defb5055
Cr-Commit-Position: refs/heads/master@{#293415}

Powered by Google App Engine
This is Rietveld 408576698