Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: extensions/renderer/script_context_browsertest.cc

Issue 537023002: Change ScriptContextTest.GetEffectiveDocumentURL to use FrameLoadWaiter and re-enable the test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/frame_load_waiter.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/renderer/render_frame.h"
6 #include "content/public/test/frame_load_waiter.h"
5 #include "content/public/test/render_view_test.h" 7 #include "content/public/test/render_view_test.h"
6 #include "extensions/renderer/script_context.h" 8 #include "extensions/renderer/script_context.h"
7 #include "third_party/WebKit/public/web/WebDocument.h" 9 #include "third_party/WebKit/public/web/WebDocument.h"
8 #include "third_party/WebKit/public/web/WebLocalFrame.h" 10 #include "third_party/WebKit/public/web/WebLocalFrame.h"
9 #include "url/gurl.h" 11 #include "url/gurl.h"
10 12
11 using blink::WebFrame; 13 using blink::WebFrame;
12 14
13 namespace extensions { 15 namespace extensions {
14 namespace { 16 namespace {
15 17
16 class ScriptContextTest : public content::RenderViewTest { 18 class ScriptContextTest : public content::RenderViewTest {
17 protected: 19 protected:
18 GURL GetEffectiveDocumentURL(const WebFrame* frame) { 20 GURL GetEffectiveDocumentURL(const WebFrame* frame) {
19 return ScriptContext::GetEffectiveDocumentURL( 21 return ScriptContext::GetEffectiveDocumentURL(
20 frame, frame->document().url(), true); 22 frame, frame->document().url(), true);
21 } 23 }
22 }; 24 };
23 25
24 // http://crbug.com/391894 26 TEST_F(ScriptContextTest, GetEffectiveDocumentURL) {
25 TEST_F(ScriptContextTest, DISABLED_GetEffectiveDocumentURL) {
26 GURL top_url("http://example.com/"); 27 GURL top_url("http://example.com/");
27 GURL different_url("http://example.net/"); 28 GURL different_url("http://example.net/");
28 GURL blank_url("about:blank"); 29 GURL blank_url("about:blank");
29 GURL srcdoc_url("about:srcdoc"); 30 GURL srcdoc_url("about:srcdoc");
30 31
31 const char frame_html[] = 32 const char frame_html[] =
32 "<iframe name='frame1' srcdoc=\"" 33 "<iframe name='frame1' srcdoc=\""
33 " <iframe name='frame1_1'></iframe>" 34 " <iframe name='frame1_1'></iframe>"
34 " <iframe name='frame1_2' sandbox=''></iframe>" 35 " <iframe name='frame1_2' sandbox=''></iframe>"
35 "\"></iframe>" 36 "\"></iframe>"
36 "<iframe name='frame2' sandbox='' srcdoc=\"" 37 "<iframe name='frame2' sandbox='' srcdoc=\""
37 " <iframe name='frame2_1'></iframe>" 38 " <iframe name='frame2_1'></iframe>"
38 "\"></iframe>" 39 "\"></iframe>"
39 "<iframe name='frame3'></iframe>"; 40 "<iframe name='frame3'></iframe>";
40 41
41 const char frame3_html[] = "<iframe name='frame3_1'></iframe>"; 42 const char frame3_html[] = "<iframe name='frame3_1'></iframe>";
42 43
43 WebFrame* frame = GetMainFrame(); 44 WebFrame* frame = GetMainFrame();
44 ASSERT_TRUE(frame); 45 ASSERT_TRUE(frame);
45 46
46 frame->loadHTMLString(frame_html, top_url); 47 frame->loadHTMLString(frame_html, top_url);
47 do { 48 content::FrameLoadWaiter(content::RenderFrame::FromWebFrame(frame)).Wait();
48 ProcessPendingMessages();
49 } while (frame->isLoading());
50 49
51 WebFrame* frame1 = frame->findChildByName("frame1"); 50 WebFrame* frame1 = frame->findChildByName("frame1");
52 ASSERT_TRUE(frame1); 51 ASSERT_TRUE(frame1);
53 WebFrame* frame1_1 = frame1->findChildByName("frame1_1"); 52 WebFrame* frame1_1 = frame1->findChildByName("frame1_1");
54 ASSERT_TRUE(frame1_1); 53 ASSERT_TRUE(frame1_1);
55 WebFrame* frame1_2 = frame1->findChildByName("frame1_2"); 54 WebFrame* frame1_2 = frame1->findChildByName("frame1_2");
56 ASSERT_TRUE(frame1_2); 55 ASSERT_TRUE(frame1_2);
57 WebFrame* frame2 = frame->findChildByName("frame2"); 56 WebFrame* frame2 = frame->findChildByName("frame2");
58 ASSERT_TRUE(frame2); 57 ASSERT_TRUE(frame2);
59 WebFrame* frame2_1 = frame2->findChildByName("frame2_1"); 58 WebFrame* frame2_1 = frame2->findChildByName("frame2_1");
60 ASSERT_TRUE(frame2_1); 59 ASSERT_TRUE(frame2_1);
61 WebFrame* frame3 = frame->findChildByName("frame3"); 60 WebFrame* frame3 = frame->findChildByName("frame3");
62 ASSERT_TRUE(frame3); 61 ASSERT_TRUE(frame3);
63 62
64 // Load a blank document in a frame from a different origin. 63 // Load a blank document in a frame from a different origin.
65 frame3->loadHTMLString(frame3_html, different_url); 64 frame3->loadHTMLString(frame3_html, different_url);
66 do { 65 content::FrameLoadWaiter(content::RenderFrame::FromWebFrame(frame3)).Wait();
67 ProcessPendingMessages();
68 } while (frame3->isLoading());
69 66
70 WebFrame* frame3_1 = frame->findChildByName("frame3"); 67 WebFrame* frame3_1 = frame->findChildByName("frame3");
71 ASSERT_TRUE(frame3_1); 68 ASSERT_TRUE(frame3_1);
72 69
73 // Top-level frame 70 // Top-level frame
74 EXPECT_EQ(GetEffectiveDocumentURL(frame), top_url); 71 EXPECT_EQ(GetEffectiveDocumentURL(frame), top_url);
75 // top -> srcdoc = inherit 72 // top -> srcdoc = inherit
76 EXPECT_EQ(GetEffectiveDocumentURL(frame1), top_url); 73 EXPECT_EQ(GetEffectiveDocumentURL(frame1), top_url);
77 // top -> srcdoc -> about:blank = inherit 74 // top -> srcdoc -> about:blank = inherit
78 EXPECT_EQ(GetEffectiveDocumentURL(frame1_1), top_url); 75 EXPECT_EQ(GetEffectiveDocumentURL(frame1_1), top_url);
79 // top -> srcdoc -> about:blank sandboxed = same URL 76 // top -> srcdoc -> about:blank sandboxed = same URL
80 EXPECT_EQ(GetEffectiveDocumentURL(frame1_2), blank_url); 77 EXPECT_EQ(GetEffectiveDocumentURL(frame1_2), blank_url);
81 78
82 // top -> srcdoc [sandboxed] = same URL 79 // top -> srcdoc [sandboxed] = same URL
83 EXPECT_EQ(GetEffectiveDocumentURL(frame2), srcdoc_url); 80 EXPECT_EQ(GetEffectiveDocumentURL(frame2), srcdoc_url);
84 // top -> srcdoc [sandboxed] -> about:blank = same URL 81 // top -> srcdoc [sandboxed] -> about:blank = same URL
85 EXPECT_EQ(GetEffectiveDocumentURL(frame2_1), blank_url); 82 EXPECT_EQ(GetEffectiveDocumentURL(frame2_1), blank_url);
86 83
87 // top -> different origin = different origin 84 // top -> different origin = different origin
88 EXPECT_EQ(GetEffectiveDocumentURL(frame3), different_url); 85 EXPECT_EQ(GetEffectiveDocumentURL(frame3), different_url);
89 // top -> different origin -> about:blank = inherit 86 // top -> different origin -> about:blank = inherit
90 EXPECT_EQ(GetEffectiveDocumentURL(frame3_1), different_url); 87 EXPECT_EQ(GetEffectiveDocumentURL(frame3_1), different_url);
91 } 88 }
92 89
93 } // namespace 90 } // namespace
94 } // namespace extensions 91 } // namespace extensions
OLDNEW
« no previous file with comments | « content/test/frame_load_waiter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698