Remove TextTrackLoaderClient::shouldLoadCues and ::cueLoadingStarted

Remove TextTrackLoaderClient::shouldLoadCues and ::cueLoadingStarted

Their only implementations (in TextTrackLoader) do nothing useful,
so just remove them until needed.

Also sprinkle some OVERRIDE in the neighborhood.

BUG=313287
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161048

[Nate Chapin, 2013-10-30 23:16:05]

lgtm

[commit-bot: I haz the power, 2013-10-31 05:12:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/53533003/1

[commit-bot: I haz the power, 2013-10-31 05:12:45]

Failed to apply patch for Source/core/loader/TextTrackLoader.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/loader/TextTrackLoader.cpp
  Hunk #2 FAILED at 138.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/loader/TextTrackLoader.cpp.rej

Patch:       Source/core/loader/TextTrackLoader.cpp
Index: Source/core/loader/TextTrackLoader.cpp
diff --git a/Source/core/loader/TextTrackLoader.cpp
b/Source/core/loader/TextTrackLoader.cpp
index
279796ad4680530e46e5cd2aaebfee61f6764712..ddba6bf5f186aad638da21c6cfb9c2d755483215
100644
--- a/Source/core/loader/TextTrackLoader.cpp
+++ b/Source/core/loader/TextTrackLoader.cpp
@@ -119,9 +119,6 @@ bool TextTrackLoader::load(const KURL& url, const String&
crossOriginMode)
 {
     cancelLoad();
 
-    if (!m_client.shouldLoadCues(this))
-        return false;
-
     FetchRequest cueRequest(ResourceRequest(m_document.completeURL(url)),
FetchInitiatorTypeNames::texttrack);
 
     if (!crossOriginMode.isNull()) {
@@ -141,7 +138,6 @@ bool TextTrackLoader::load(const KURL& url, const String&
crossOriginMode)
     if (!m_resource)
         return false;
     m_resource->addClient(this);
-    m_client.cueLoadingStarted(this);
     return true;
 }

[philipj_slow, 2013-10-31 08:01:37]

This failed because it builds on <https://codereview.chromium.org/53213002/>,
will try again when that has landed.

[commit-bot: I haz the power, 2013-10-31 09:24:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/53533003/1

[commit-bot: I haz the power, 2013-10-31 10:55:38]

Change committed as 161048