Source/core/html/track/LoadableTextTrack.h - Issue 53533003: Remove TextTrackLoaderClient::shouldLoadCues and ::cueLoadingStarted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/LoadableTextTrack.h

Issue 53533003: Remove TextTrackLoaderClient::shouldLoadCues and ::cueLoadingStarted (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@fetchRawResourceNull

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/track/LoadableTextTrack.h

diff --git a/Source/core/html/track/LoadableTextTrack.h b/Source/core/html/track/LoadableTextTrack.h

index 5db3e5e2f8c8e48615bd57df028a94f22d1ac692..36228d10cdd5425351b85a52be542c92cd766d10 100644

--- a/Source/core/html/track/LoadableTextTrack.h

+++ b/Source/core/html/track/LoadableTextTrack.h

@@ -63,11 +63,9 @@ public:

private:

// TextTrackLoaderClient

- virtual bool shouldLoadCues(TextTrackLoader*) { return true; }

- virtual void newCuesAvailable(TextTrackLoader*);

- virtual void cueLoadingStarted(TextTrackLoader*);

- virtual void cueLoadingCompleted(TextTrackLoader*, bool loadingFailed);

- virtual void newRegionsAvailable(TextTrackLoader*);

+ virtual void newCuesAvailable(TextTrackLoader*) OVERRIDE;

+ virtual void cueLoadingCompleted(TextTrackLoader*, bool loadingFailed) OVERRIDE;

+ virtual void newRegionsAvailable(TextTrackLoader*) OVERRIDE;

LoadableTextTrack(HTMLTrackElement*, const String& kind, const String& label, const String& language);

« no previous file with comments | « no previous file | Source/core/html/track/LoadableTextTrack.cpp » ('j') | no next file with comments »