Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 533883004: Remove GrDrawTarget::AutoRenderTargetRestore. (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove GrDrawTarget::AutoRenderTargetRestore. Pass GrRenderTarget in GrGpuG clear\bind methods. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/b0bd4f64a6827dda6f4ec48e4746b0f0b72a975f

Patch Set 1 #

Patch Set 2 : pass rt to clearStencilClip #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -104 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +0 lines, -34 lines 0 comments Download
M src/gpu/GrGpu.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M src/gpu/GrRODrawState.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 4 chunks +8 lines, -6 lines 2 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 12 chunks +35 lines, -48 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bsalomon
The point of this is to stop temporarily changing GrDrawState's render target as a way ...
6 years, 3 months ago (2014-09-02 21:21:00 UTC) #2
egdaniel
https://codereview.chromium.org/533883004/diff/20001/src/gpu/gl/GrGpuGL.h File src/gpu/gl/GrGpuGL.h (right): https://codereview.chromium.org/533883004/diff/20001/src/gpu/gl/GrGpuGL.h#newcode222 src/gpu/gl/GrGpuGL.h:222: void flushScissor(const GrGLIRect& rtViewport, GrSurfaceOrigin rtOrigin); why not pass ...
6 years, 3 months ago (2014-09-03 13:34:35 UTC) #3
bsalomon
https://codereview.chromium.org/533883004/diff/20001/src/gpu/gl/GrGpuGL.h File src/gpu/gl/GrGpuGL.h (right): https://codereview.chromium.org/533883004/diff/20001/src/gpu/gl/GrGpuGL.h#newcode222 src/gpu/gl/GrGpuGL.h:222: void flushScissor(const GrGLIRect& rtViewport, GrSurfaceOrigin rtOrigin); On 2014/09/03 13:34:35, ...
6 years, 3 months ago (2014-09-03 13:49:46 UTC) #4
egdaniel
lgtm
6 years, 3 months ago (2014-09-03 14:00:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/533883004/20001
6 years, 3 months ago (2014-09-03 14:12:16 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 14:19:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as b0bd4f64a6827dda6f4ec48e4746b0f0b72a975f

Powered by Google App Engine
This is Rietveld 408576698