Issue 53293004: Remove unnecessary ContentBrowserClient in test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53293004: Remove unnecessary ContentBrowserClient in test. (Closed)

Created:
7 years, 1 month ago by Charlie Reis

Modified:
7 years, 1 month ago

Reviewers:
nasko

CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unnecessary ContentBrowserClient in test. DevToolsManagerTest was forcing a process swap using ShouldSwapProcessesForNavigation, but this was unnecessary since the navigation was cross-site anyway. Removing the extra code so that it doesn't force an unnecessary swap on the first navigation. BUG=123007 TEST=DevToolsManagerTest.ReattachOnCancelPendingNavigation Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232916

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -28 lines)			Patch
	M	content/browser/devtools/devtools_manager_unittest.cc	View		2 chunks	+0 lines, -28 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Nasko, I'm trying to revive https://codereview.chromium.org/19021004/, and I figured I'd land this part first since ...

7 years, 1 month ago (2013-11-04 23:05:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/53293004/1

7 years, 1 month ago (2013-11-05 00:22:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/53293004/1

7 years, 1 month ago (2013-11-05 03:10:19 UTC) #5

Message was sent while issue was closed.

Change committed as 232916

Expand Messages | Collapse Messages