Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: content/browser/devtools/devtools_manager_unittest.cc

Issue 53293004: Remove unnecessary ContentBrowserClient in test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_manager_unittest.cc
diff --git a/content/browser/devtools/devtools_manager_unittest.cc b/content/browser/devtools/devtools_manager_unittest.cc
index 46c198cc05cc61320fe94fbf1a5a4729a55f6606..f223c6020c7d1d9521793cef54ace7d57423b383 100644
--- a/content/browser/devtools/devtools_manager_unittest.cc
+++ b/content/browser/devtools/devtools_manager_unittest.cc
@@ -87,41 +87,14 @@ class TestWebContentsDelegate : public WebContentsDelegate {
bool renderer_unresponsive_received_;
};
-class DevToolsManagerTestBrowserClient : public TestContentBrowserClient {
- public:
- DevToolsManagerTestBrowserClient() {
- }
-
- virtual bool ShouldSwapProcessesForNavigation(
- SiteInstance* site_instance,
- const GURL& current_url,
- const GURL& new_url) OVERRIDE {
- return true;
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(DevToolsManagerTestBrowserClient);
-};
-
} // namespace
class DevToolsManagerTest : public RenderViewHostImplTestHarness {
protected:
virtual void SetUp() OVERRIDE {
- original_browser_client_ = SetBrowserClientForTesting(&browser_client_);
-
RenderViewHostImplTestHarness::SetUp();
TestDevToolsClientHost::ResetCounters();
}
-
- virtual void TearDown() OVERRIDE {
- RenderViewHostImplTestHarness::TearDown();
- SetBrowserClientForTesting(original_browser_client_);
- }
-
- private:
- ContentBrowserClient* original_browser_client_;
- DevToolsManagerTestBrowserClient browser_client_;
};
TEST_F(DevToolsManagerTest, OpenAndManuallyCloseDevToolsClientHost) {
@@ -200,7 +173,6 @@ TEST_F(DevToolsManagerTest, NoUnresponsiveDialogInInspectedContents) {
}
TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {
- contents()->transition_cross_site = true;
// Navigate to URL. First URL should use first RenderViewHost.
const GURL url("http://www.google.com");
controller().LoadURL(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698