Issue 19021004: Prevent creating a swapped out RVH in the same SiteInstance as the current one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19021004: Prevent creating a swapped out RVH in the same SiteInstance as the current one. (Closed)

Created:
7 years, 5 months ago by Charlie Reis

Modified:
7 years ago

Reviewers:
nasko

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Fady Samuel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Prevent creating a swapped out RVH in the same SiteInstance as the current one. BUG=258993

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -43 lines)			Patch
M	content/browser/devtools/devtools_manager_unittest.cc	View	1	2 chunks	+0 lines, -28 lines	0 comments	Download
M	content/browser/site_instance_impl.h	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/web_contents/render_view_host_manager.cc	View	1 2	2 chunks	+21 lines, -10 lines	0 comments	Download
M	content/browser/web_contents/render_view_host_manager_unittest.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Charlie Reis

This fixes an issue I noticed in https://chromiumcodereview.appspot.com/18512004/.

7 years, 5 months ago (2013-07-10 21:13:15 UTC) #1

lgtm