Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 5326011: Check that TabContents is valid (not null) before removing theme change InfoBar. (Closed)

Created:
8 years, 9 months ago by Tessa MacDuff
Modified:
8 years, 3 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Check that TabContents is valid (not null) before removing theme change InfoBar. BUG=60761 TEST=interactive_ui_tests and repro steps in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68112

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 1 1 chunk +16 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tessa MacDuff
One more attempt to fix the theme-change crashing bug.
8 years, 9 months ago (2010-11-30 22:23:41 UTC) #1
Aaron Boodman
lgtm http://codereview.chromium.org/5326011/diff/1/chrome/browser/extensions/theme_installed_infobar_delegate.cc File chrome/browser/extensions/theme_installed_infobar_delegate.cc (right): http://codereview.chromium.org/5326011/diff/1/chrome/browser/extensions/theme_installed_infobar_delegate.cc#newcode107 chrome/browser/extensions/theme_installed_infobar_delegate.cc:107: // it is still needed if we "undo" ...
8 years, 9 months ago (2010-12-01 01:06:05 UTC) #2
Tessa MacDuff
and uploaded http://codereview.chromium.org/5326011/diff/1/chrome/browser/extensions/theme_installed_infobar_delegate.cc File chrome/browser/extensions/theme_installed_infobar_delegate.cc (right): http://codereview.chromium.org/5326011/diff/1/chrome/browser/extensions/theme_installed_infobar_delegate.cc#newcode107 chrome/browser/extensions/theme_installed_infobar_delegate.cc:107: // it is still needed if we ...
8 years, 9 months ago (2010-12-01 19:16:37 UTC) #3
Aaron Boodman
8 years, 9 months ago (2010-12-02 20:34:03 UTC) #4
Thanks, still lg

Powered by Google App Engine
This is Rietveld 408576698