Check that TabContents is valid (not null) before removing theme change InfoBar.

chrome/browser/extensions/theme_installed_infobar_delegate.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/theme_installed_infobar_delegate.h"
 
 #include <string>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
@@ skipping 80 matching lines @@
 }
 
 void ThemeInstalledInfoBarDelegate::Observe(
     NotificationType type,
     const NotificationSource& source,
     const NotificationDetails& details) {
   DCHECK_EQ(NotificationType::BROWSER_THEME_CHANGED, type.value);
   // If the new theme is different from what this info bar is associated
   // with, close this info bar since it is no longer relevant.
   const Extension* extension = Details<const Extension>(details).ptr();
-  if (!extension || theme_id_ != extension->id())
-    tab_contents_->RemoveInfoBar(this);
+  if (!extension || theme_id_ != extension->id()) {
+    if (tab_contents_ && !tab_contents_->is_being_destroyed()) {
+      tab_contents_->RemoveInfoBar(this);
+      // The infobar is gone so there is no reason for this delegate to keep
+      // a pointer to the tab_contents (a new delegate will be created if a new
+      // infobar is created).  The delegate can not be deleted yet because
+      // it is still needed if we "undo" the theme change that triggered

[Aaron Boodman, 2010/12/01 01:06:06]

I think it would probably be good to reference the bug that peter is working on
here and explain why we can't just delete ourselves here.

[Tessa MacDuff, 2010/12/01 19:16:37]

Done.

+      // this notification.
+      tab_contents_ = NULL;
+    }
+  }
 }
 
 bool ThemeInstalledInfoBarDelegate::MatchesTheme(const Extension* theme) {
   return (theme && theme->id() == theme_id_);
 }