Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 53133002: Make not-reusing-scratch-textures only apply to texture uploads (Closed)

Created:
7 years, 1 month ago by robertphillips
Modified:
7 years, 1 month ago
Reviewers:
bsalomon
CC:
skia-review_google.com
Visibility:
Public.

Description

It is believed that we can actually reuse scratch textures that are only rendered to (rather than uploaded to).

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M src/gpu/GrClipMaskManager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrContext.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
Not yet tested on Android but you can have a look.
7 years, 1 month ago (2013-10-30 19:06:00 UTC) #1
bsalomon
lgtm
7 years, 1 month ago (2013-10-30 19:14:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/53133002/30001
7 years, 1 month ago (2013-10-30 19:55:41 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
7 years, 1 month ago (2013-10-30 20:02:15 UTC) #4
robertphillips
7 years, 1 month ago (2013-10-30 21:31:02 UTC) #5
Message was sent while issue was closed.
committed as r12037

Powered by Google App Engine
This is Rietveld 408576698