bindings: Retires manual dispatching in createV8{HTML,SVG}Wrapper, etc.

Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

Index: Source/bindings/core/v8/custom/V8MessageEventCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp b/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp
index 2337363283885422c224119091a2187ce50f022e..b0090361c53a9853e44dc5c17a8c64f2101a2e17 100644
--- a/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp
@@ -42,37 +42,6 @@
 
 namespace blink {
 
-// Ensures a wrapper is created for the data to return now so that V8 knows how
-// much memory is used via the wrapper. To keep the wrapper alive, it's set to
-// the wrapper of the MessageEvent as a hidden value.
-static void ensureWrapperCreatedAndAssociated(MessageEvent* eventImpl, v8::Handle<v8::Object> eventWrapper, v8::Isolate* isolate)

[haraken, 2014/09/04 02:17:46]

Why do we have the setHiddenValue code in both V8MessageEventCustom.cpp and
MessageEvent.cpp.

[Yuki, 2014/09/04 04:47:29]

It's because we have two paths to create wrappers.  blink::wrap(MessageEvent*
impl, ...) and blink::ScriptWrappable::wrap(...).

This CL retires the former old one.
We're moving to the new code step by step.  Some of the old code is no longer
used, and some of the old code is used via different paths.

-{
-    switch (eventImpl->dataType()) {
-    case MessageEvent::DataTypeScriptValue:
-    case MessageEvent::DataTypeSerializedScriptValue:
-        break;
-    case MessageEvent::DataTypeString: {
-        String stringValue = eventImpl->dataAsString();
-        V8HiddenValue::setHiddenValue(isolate, eventWrapper, V8HiddenValue::stringData(isolate), v8String(isolate, stringValue));
-        break;
-    }
-    case MessageEvent::DataTypeBlob:
-        break;
-    case MessageEvent::DataTypeArrayBuffer:
-        V8HiddenValue::setHiddenValue(isolate, eventWrapper, V8HiddenValue::arrayBufferData(isolate), toV8(eventImpl->dataAsArrayBuffer(), eventWrapper, isolate));
-        break;
-    }
-}
-
-v8::Handle<v8::Object> wrap(MessageEvent* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
-{
-    ASSERT(impl);
-    ASSERT(!DOMDataStore::containsWrapper<V8MessageEvent>(impl, isolate));
-    v8::Handle<v8::Object> wrapper = V8MessageEvent::createWrapper(impl, creationContext, isolate);
-    ensureWrapperCreatedAndAssociated(impl, wrapper, isolate);
-    return wrapper;
-}
-
 void V8MessageEvent::dataAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     MessageEvent* event = V8MessageEvent::toNative(info.Holder());