bindings: Retires manual dispatching in createV8{HTML,SVG}Wrapper, etc.

Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 24 matching lines @@
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8Blob.h"
 #include "bindings/core/v8/V8HiddenValue.h"
 #include "bindings/core/v8/V8MessagePort.h"
 #include "bindings/core/v8/V8Window.h"
 #include "bindings/core/v8/custom/V8ArrayBufferCustom.h"
 #include "core/events/MessageEvent.h"
 
 namespace blink {
 
-// Ensures a wrapper is created for the data to return now so that V8 knows how
-// much memory is used via the wrapper. To keep the wrapper alive, it's set to
-// the wrapper of the MessageEvent as a hidden value.
-static void ensureWrapperCreatedAndAssociated(MessageEvent* eventImpl, v8::Handle<v8::Object> eventWrapper, v8::Isolate* isolate)

[haraken, 2014/09/04 02:17:46]

Why do we have the setHiddenValue code in both V8MessageEventCustom.cpp and
MessageEvent.cpp.

[Yuki, 2014/09/04 04:47:29]

It's because we have two paths to create wrappers.  blink::wrap(MessageEvent*
impl, ...) and blink::ScriptWrappable::wrap(...).

This CL retires the former old one.
We're moving to the new code step by step.  Some of the old code is no longer
used, and some of the old code is used via different paths.

-{
-    switch (eventImpl->dataType()) {
-    case MessageEvent::DataTypeScriptValue:
-    case MessageEvent::DataTypeSerializedScriptValue:
-        break;
-    case MessageEvent::DataTypeString: {
-        String stringValue = eventImpl->dataAsString();
-        V8HiddenValue::setHiddenValue(isolate, eventWrapper, V8HiddenValue::stringData(isolate), v8String(isolate, stringValue));
-        break;
-    }
-    case MessageEvent::DataTypeBlob:
-        break;
-    case MessageEvent::DataTypeArrayBuffer:
-        V8HiddenValue::setHiddenValue(isolate, eventWrapper, V8HiddenValue::arrayBufferData(isolate), toV8(eventImpl->dataAsArrayBuffer(), eventWrapper, isolate));
-        break;
-    }
-}
-
-v8::Handle<v8::Object> wrap(MessageEvent* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
-{
-    ASSERT(impl);
-    ASSERT(!DOMDataStore::containsWrapper<V8MessageEvent>(impl, isolate));
-    v8::Handle<v8::Object> wrapper = V8MessageEvent::createWrapper(impl, creationContext, isolate);
-    ensureWrapperCreatedAndAssociated(impl, wrapper, isolate);
-    return wrapper;
-}
-
 void V8MessageEvent::dataAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     MessageEvent* event = V8MessageEvent::toNative(info.Holder());
 
     v8::Handle<v8::Value> result;
     switch (event->dataType()) {
     case MessageEvent::DataTypeScriptValue: {
         result = V8HiddenValue::getHiddenValue(info.GetIsolate(), info.Holder(), V8HiddenValue::data(info.GetIsolate()));
         if (result.IsEmpty()) {
             if (!event->dataAsSerializedScriptValue()) {
@@ skipping 69 matching lines @@
     event->initMessageEvent(typeArg, canBubbleArg, cancelableArg, originArg, lastEventIdArg, sourceArg, portArray.release());
 
     if (!dataArg.IsEmpty()) {
         V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), V8HiddenValue::data(info.GetIsolate()), dataArg);
         if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld())
             event->setSerializedData(SerializedScriptValue::createAndSwallowExceptions(dataArg, info.GetIsolate()));
     }
 }
 
 } // namespace blink