bindings: Retires manual dispatching in createV8{HTML,SVG}Wrapper, etc.

Source/bindings/core/v8/custom/V8ImageDataCustom.cpp

Index: Source/bindings/core/v8/custom/V8ImageDataCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8ImageDataCustom.cpp b/Source/bindings/core/v8/custom/V8ImageDataCustom.cpp
deleted file mode 100644
index 785cf0e7e22654c818315fb0d68dac35b201adaa..0000000000000000000000000000000000000000
--- a/Source/bindings/core/v8/custom/V8ImageDataCustom.cpp
+++ /dev/null
@@ -1,55 +0,0 @@
-/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- *     * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- *     * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "bindings/core/v8/V8ImageData.h"
-
-#include "bindings/core/v8/custom/V8Uint8ClampedArrayCustom.h"
-
-namespace blink {
-
-v8::Handle<v8::Object> wrap(ImageData* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
-{
-    ASSERT(impl);
-    v8::Handle<v8::Object> wrapper = V8ImageData::createWrapper(impl, creationContext, isolate);
-    if (!wrapper.IsEmpty()) {
-        // Create a V8 Uint8ClampedArray object.
-        v8::Handle<v8::Value> pixelArray = toV8(impl->data(), creationContext, isolate);
-        // Set the "data" property of the ImageData object to
-        // the created v8 object, eliminating the C++ callback
-        // when accessing the "data" property.
-        if (!pixelArray.IsEmpty())
-            wrapper->ForceSet(v8AtomicString(isolate, "data"), pixelArray, v8::ReadOnly);

[haraken, 2014/09/04 02:17:46]

It looks wrong to remove this code. We still need this. That's why a couple of
ImageData tests are failing in try bots.

[Yuki, 2014/09/04 04:47:29]

We already have the new version of this code at
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

So it should be fine to remove this code.

-    }
-
-    return wrapper;
-}
-
-} // namespace blink