athena: Move windows in the stack backwards if the back-most window is closed.

athena: Move windows in the stack backwards if the back-most window is closed.

When in overview mode, if a window is closed, then the rest of the windows
that behind the closed window in the stack are moved on step forward. However,
if there are no windows behind the closed window, then move the windows in
front of the closed window backward one step.

BUG=408280
R=oshima@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/df33c5cdd1b267d879bb0e31250e4570871c0726

[sadrul, 2014-09-02 17:34:32]

sadrul@chromium.org changed reviewers:
+ oshima@chromium.org

[sadrul, 2014-09-03 19:23:50]

ping

[oshima, 2014-09-03 19:50:36]

lgtm with nits

https://codereview.chromium.org/531093003/diff/1/athena/wm/window_overview_mo...
File athena/wm/window_overview_mode.cc (right):

https://codereview.chromium.org/531093003/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:192: void
UpdateTerminalStateForWindowAtIndex(aura::Window* window,
can you document this method?

https://codereview.chromium.org/531093003/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:421: ui::ScopedLayerAnimationSettings
settings(
optional:

the scope of this object out lives other scoped settings object
for other objects. I understand that that want't cause the problem,
but you may want to define a block for dragged_window_ animation.

https://codereview.chromium.org/531093003/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:446: if (list.empty())
CHECK? (if you have dragged_window_, this shouldn't be empty?)

[sadrul, 2014-09-03 20:24:37]

https://codereview.chromium.org/531093003/diff/1/athena/wm/window_overview_mo...
File athena/wm/window_overview_mode.cc (right):

https://codereview.chromium.org/531093003/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:192: void
UpdateTerminalStateForWindowAtIndex(aura::Window* window,
On 2014/09/03 19:50:35, oshima wrote:
> can you document this method?

Done.

https://codereview.chromium.org/531093003/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:421: ui::ScopedLayerAnimationSettings
settings(
On 2014/09/03 19:50:35, oshima wrote:
> optional:
> 
> the scope of this object out lives other scoped settings object
> for other objects. I understand that that want't cause the problem,
> but you may want to define a block for dragged_window_ animation.

Done.

https://codereview.chromium.org/531093003/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:446: if (list.empty())
On 2014/09/03 19:50:35, oshima wrote:
> CHECK? (if you have dragged_window_, this shouldn't be empty?)

Good point. Done.

[sadrul, 2014-09-03 21:18:19]

Committed patchset #2 (id:20001) manually as df33c5c (presubmit successful).

[commit-bot: I haz the power, 2014-09-10 03:27:45]

Patchset 2 (id:??) landed as
https://crrev.com/df33c5cdd1b267d879bb0e31250e4570871c0726
Cr-Commit-Position: refs/heads/master@{#293196}