Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 530373002: [fsp] Remove length from the OnWriteFileOperation(). (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 3 months ago
Reviewers:
benwells, fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Remove length from the OnWriteFileOperation(). The length is already available as data.byteLength, where data is of the ArrayBuffer type. TBR=benwells@chromium.org TEST=browser_tests, unit_tests: *FileSystemProvider*Write* BUG=248427 Committed: https://crrev.com/3485d1a05e0cc3ad01d363cdfea6786d2368080b Cr-Commit-Position: refs/heads/master@{#293093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/browser/chromeos/file_system_provider/operations/write_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc View 8 chunks +15 lines, -11 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
mtomasz
@fukino: PTAL. Thanks.
6 years, 3 months ago (2014-09-03 04:37:44 UTC) #2
fukino
On 2014/09/03 04:37:44, mtomasz wrote: > @fukino: PTAL. Thanks. lgtm!
6 years, 3 months ago (2014-09-03 06:15:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/530373002/1
6 years, 3 months ago (2014-09-03 06:31:11 UTC) #5
mtomasz
@benwells: TBR for a trivial change in IDL.
6 years, 3 months ago (2014-09-03 06:43:42 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-03 07:29:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 40cbc3b01c00ba196f8b689868d54a291e11a121
6 years, 3 months ago (2014-09-03 07:35:05 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3485d1a05e0cc3ad01d363cdfea6786d2368080b
Cr-Commit-Position: refs/heads/master@{#293093}

Powered by Google App Engine
This is Rietveld 408576698