[fsp] Remove length from the OnWriteFileOperation().

chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_system_provider/operations/write_file.h"
 
 #include <string>
 
 #include "base/files/file.h"
 #include "base/files/file_path.h"
@@ skipping 11 matching lines @@
 
 namespace chromeos {
 namespace file_system_provider {
 namespace operations {
 namespace {
 
 const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";
 const char kFileSystemId[] = "testing-file-system";
 const int kRequestId = 2;
 const int kFileHandle = 3;
+const char kWriteData[] = "Welcome to my world!";
 const int kOffset = 10;
-const int kLength = 5;
 
 }  // namespace
 
 class FileSystemProviderOperationsWriteFileTest : public testing::Test {
  protected:
   FileSystemProviderOperationsWriteFileTest() {}
   virtual ~FileSystemProviderOperationsWriteFileTest() {}
 
   virtual void SetUp() OVERRIDE {
     file_system_info_ =
         ProvidedFileSystemInfo(kExtensionId,
                                kFileSystemId,
                                "" /* display_name */,
                                true /* writable */,
                                base::FilePath() /* mount_path */);
-    io_buffer_ = make_scoped_refptr(new net::IOBuffer(kOffset + kLength));
+    io_buffer_ = make_scoped_refptr(new net::StringIOBuffer(kWriteData));
   }
 
   ProvidedFileSystemInfo file_system_info_;
-  scoped_refptr<net::IOBuffer> io_buffer_;
+  scoped_refptr<net::StringIOBuffer> io_buffer_;
 };
 
 TEST_F(FileSystemProviderOperationsWriteFileTest, Execute) {
   util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   util::StatusCallbackLog callback_log;
 
   WriteFile write_file(NULL,
                        file_system_info_,
                        kFileHandle,
                        io_buffer_.get(),
                        kOffset,
-                       kLength,
+                       io_buffer_->size(),
                        base::Bind(&util::LogStatusCallback, &callback_log));
   write_file.SetDispatchEventImplForTesting(
       base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_TRUE(write_file.Execute(kRequestId));
 
   ASSERT_EQ(1u, dispatcher.events().size());
   extensions::Event* event = dispatcher.events()[0];
   EXPECT_EQ(
@@ skipping 14 matching lines @@
   EXPECT_EQ(kRequestId, event_request_id);
 
   int event_file_handle = -1;
   EXPECT_TRUE(options->GetInteger("openRequestId", &event_file_handle));
   EXPECT_EQ(kFileHandle, event_file_handle);
 
   double event_offset = -1;
   EXPECT_TRUE(options->GetDouble("offset", &event_offset));
   EXPECT_EQ(kOffset, static_cast<double>(event_offset));
 
-  int event_length = -1;
-  EXPECT_TRUE(options->GetInteger("length", &event_length));
-  EXPECT_EQ(kLength, event_length);
+  base::BinaryValue* event_data = NULL;
+  ASSERT_TRUE(options->GetBinary("data", &event_data));
+  EXPECT_EQ(static_cast<size_t>(io_buffer_->size()), event_data->GetSize());
+  char* const event_data_buffer = event_data->GetBuffer();
+  ASSERT_TRUE(event_data_buffer);
+  EXPECT_EQ(std::string(kWriteData),
+            std::string(event_data_buffer, event_data->GetSize()));
 }
 
 TEST_F(FileSystemProviderOperationsWriteFileTest, Execute_NoListener) {
   util::LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */);
   util::StatusCallbackLog callback_log;
 
   WriteFile write_file(NULL,
                        file_system_info_,
                        kFileHandle,
                        io_buffer_.get(),
                        kOffset,
-                       kLength,
+                       io_buffer_->size(),
                        base::Bind(&util::LogStatusCallback, &callback_log));
   write_file.SetDispatchEventImplForTesting(
       base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_FALSE(write_file.Execute(kRequestId));
 }
 
 TEST_F(FileSystemProviderOperationsWriteFileTest, Execute_ReadOnly) {
   util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   util::StatusCallbackLog callback_log;
 
   const ProvidedFileSystemInfo read_only_file_system_info(
         kExtensionId,
         kFileSystemId,
         "" /* file_system_name */,
         false /* writable */,
         base::FilePath() /* mount_path */);
 
   WriteFile write_file(NULL,
                        read_only_file_system_info,
                        kFileHandle,
                        io_buffer_.get(),
                        kOffset,
-                       kLength,
+                       io_buffer_->size(),
                        base::Bind(&util::LogStatusCallback, &callback_log));
   write_file.SetDispatchEventImplForTesting(
       base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_FALSE(write_file.Execute(kRequestId));
 }
 
 TEST_F(FileSystemProviderOperationsWriteFileTest, OnSuccess) {
   util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   util::StatusCallbackLog callback_log;
 
   WriteFile write_file(NULL,
                        file_system_info_,
                        kFileHandle,
                        io_buffer_.get(),
                        kOffset,
-                       kLength,
+                       io_buffer_->size(),
                        base::Bind(&util::LogStatusCallback, &callback_log));
   write_file.SetDispatchEventImplForTesting(
       base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_TRUE(write_file.Execute(kRequestId));
 
   write_file.OnSuccess(kRequestId,
                        scoped_ptr<RequestValue>(new RequestValue()),
                        false /* has_more */);
   ASSERT_EQ(1u, callback_log.size());
   EXPECT_EQ(base::File::FILE_OK, callback_log[0]);
 }
 
 TEST_F(FileSystemProviderOperationsWriteFileTest, OnError) {
   util::LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   util::StatusCallbackLog callback_log;
 
   WriteFile write_file(NULL,
                        file_system_info_,
                        kFileHandle,
                        io_buffer_.get(),
                        kOffset,
-                       kLength,
+                       io_buffer_->size(),
                        base::Bind(&util::LogStatusCallback, &callback_log));
   write_file.SetDispatchEventImplForTesting(
       base::Bind(&util::LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_TRUE(write_file.Execute(kRequestId));
 
   write_file.OnError(kRequestId,
                      scoped_ptr<RequestValue>(new RequestValue()),
                      base::File::FILE_ERROR_TOO_MANY_OPENED);
 
   ASSERT_EQ(1u, callback_log.size());
   EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, callback_log[0]);
 }
 
 }  // namespace operations
 }  // namespace file_system_provider
 }  // namespace chromeos