chrome/browser/chromeos/file_system_provider/operations/write_file.cc - Issue 530373002: [fsp] Remove length from the OnWriteFileOperation().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/write_file.cc

Issue 530373002: [fsp] Remove length from the OnWriteFileOperation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/file_system_provider/operations/write_file.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/write_file.cc b/chrome/browser/chromeos/file_system_provider/operations/write_file.cc

index c893eff40f62a19602c7d220b7ca0ff4be98d06b..df4c10ada5c86c600c4e688a4196f84469d1c3e6 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/write_file.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/write_file.cc

@@ -40,7 +40,7 @@ bool WriteFile::Execute(int request_id) {

scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue);

values->SetInteger("openRequestId", file_handle_);

values->SetDouble("offset", offset_);

- values->SetInteger("length", length_);

+ // Length is not passed directly since it can be accessed via data.byteLength.

DCHECK(buffer_.get());

values->Set(

« no previous file with comments | « no previous file | chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc » ('j') | no next file with comments »