Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 530343003: Landing Recent QUIC Changes. (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, alyssar, Jana, Ian Swett, rjshade
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0828
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC Changes. Remove unused QUIC_VERSION_20. We are already speaking QUIC_VERSION_21 in the wild, and QUIC_VERSION_20 was never intended to be used. Not much code removed in this CL, but should make end to end tests a bit faster. Merge internal change: 74594489 https://codereview.chromium.org/532093002/ Change GetLeastUnacked() to return the next packet that could be sent when there are no packets in flight instead of 0. This should help solve the problem we are seeing in trace logs from internal servers where the ack line drops to 0. Merge internal change: 74396185 https://codereview.chromium.org/530343002/ Change IsRetransmittable to not check transmission type but instead let ShouldDiscardPacket check it directly. Merge internal change: 74359363 https://codereview.chromium.org/536743002/ Change the QUIC CongestionMap to be based on a vector. Saves ~0.75% CPU when profiling. Merge internal change: 74321352 https://codereview.chromium.org/528083004/ Some improvements to quic_client_bin. - user can supply specific version - added a number of comments - added a number of descriptive ERROR logs on failure - removed unneeded flow control options (SetDefaults covers this) Merge internal change: 74309904 https://codereview.chromium.org/532073002/ R=rch@chromium.org Committed: https://crrev.com/16142b6bac36b5058f36d89e96c9f7c8ad8bf707 Cr-Commit-Position: refs/heads/master@{#293208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -124 lines) Patch
M net/quic/congestion_control/pacing_sender.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/pacing_sender_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_simulator.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 4 chunks +13 lines, -9 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +2 lines, -4 lines 0 comments Download
M net/quic/quic_connection.cc View 7 chunks +12 lines, -17 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_headers_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 5 chunks +8 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M net/quic/quic_session.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_bin.cc View 4 chunks +42 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
6 years, 3 months ago (2014-09-03 02:21:59 UTC) #1
Ryan Hamilton
lgtm
6 years, 3 months ago (2014-09-03 18:22:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/530343003/1
6 years, 3 months ago (2014-09-03 18:38:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 25a0f8dc9f50d157a2c4cc8d2b0bbdd15f5e607c
6 years, 3 months ago (2014-09-03 21:54:10 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:28:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16142b6bac36b5058f36d89e96c9f7c8ad8bf707
Cr-Commit-Position: refs/heads/master@{#293208}

Powered by Google App Engine
This is Rietveld 408576698