Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 532073002: Some improvements to quic_client_bin. (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0828
Project:
chromium
Visibility:
Public.

Description

Some improvements to quic_client_bin. - user can supply specific version - added a number of comments - added a number of descriptive ERROR logs on failure - removed unneeded flow control options (SetDefaults covers this) Merge internal change: 74309904 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -30 lines) Patch
M net/tools/quic/quic_client_bin.cc View 4 chunks +42 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 3 months ago (2014-09-03 01:42:01 UTC) #1
Ryan Hamilton
6 years, 3 months ago (2014-09-03 18:18:41 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698