Issue 530343002: Change GetLeastUnacked() to return the next packet that could be sent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 530343002: Change GetLeastUnacked() to return the next packet that could be sent (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)

Modified:
6 years, 3 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@IsRetransmittable_74359363

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change GetLeastUnacked() to return the next packet that could be sent when there are no packets in flight instead of 0. This should help solve the problem we are seeing in trace logs from internal servers where the ack line drops to 0. Merge internal change: 74396185 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -23 lines)			Patch
M	net/quic/quic_connection.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	3 chunks	+12 lines, -12 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages