Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 52903003: Exclude verylargebitmap test from replay modes on windows. (Closed)

Created:
7 years, 1 month ago by bsalomon
Modified:
7 years, 1 month ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Exclude verylargebitmap test from replay modes on windows. BUG=skia:1756 Committed: http://code.google.com/p/skia/source/detail?r=12030

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M gm/verylargebitmap.cpp View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
7 years, 1 month ago (2013-10-30 17:56:20 UTC) #1
epoger
LGTM with suggestion https://codereview.chromium.org/52903003/diff/1/gm/verylargebitmap.cpp File gm/verylargebitmap.cpp (right): https://codereview.chromium.org/52903003/diff/1/gm/verylargebitmap.cpp#newcode105 gm/verylargebitmap.cpp:105: return kSkipPicture_Flag | Please add a ...
7 years, 1 month ago (2013-10-30 18:08:50 UTC) #2
bsalomon
https://codereview.chromium.org/52903003/diff/1/gm/verylargebitmap.cpp File gm/verylargebitmap.cpp (right): https://codereview.chromium.org/52903003/diff/1/gm/verylargebitmap.cpp#newcode105 gm/verylargebitmap.cpp:105: return kSkipPicture_Flag | On 2013/10/30 18:08:50, epoger wrote: > ...
7 years, 1 month ago (2013-10-30 18:12:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/52903003/60001
7 years, 1 month ago (2013-10-30 18:12:59 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 18:58:05 UTC) #5
Message was sent while issue was closed.
Change committed as 12030

Powered by Google App Engine
This is Rietveld 408576698