Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 528413002: Revert 181330 "Revert 180822 "Specify clip rects when drawing Ma..." (Closed)

Created:
6 years, 3 months ago by amineer_google
Modified:
6 years, 3 months ago
Reviewers:
amineer
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Revert 181330 "Revert 180822 "Specify clip rects when drawing Ma..." Reverting my revert - per Chris, performance will be awful due to changes which have landed on top of this. BUG=409708 > Revert 180822 "Specify clip rects when drawing Mac native widgets" > > Speculatively reverting to address scrollbar dev blocker > BUG=409708 > Note there were some conflicts in the TestExpectations file, I did not try to resolve > > > Specify clip rects when drawing Mac native widgets > > > > Add the clip rect as an argument to LocalCurrentGraphicsContext, > > and specify the rect for all callers. Add the rect argument for the one > > direct caller to SkiaBitLocker (the argument will be made a requirement > > once this lands). > > > > De-duplicate a bunch of rectangle-inflating code and move it into > > ThemeMac. > > > > For the selected widgets that draw their own focus rings (most don't), > > simply specify the maximum inflation of the clip rect as 16 pixels on > > each side. This appears to be very generous. The correct API call to > > compute this, focusRingMaskBoundsForFrame, was introduced in the > > 10.7 API, and the widgets that draw their own focus rings wouldn't > > need to do so if written against the the 10.7 API. > > > > BUG=247716 > > > > Review URL: https://codereview.chromium.org/488353003 > > TBR=ccameron@chromium.org > > Review URL: https://codereview.chromium.org/536973002 TBR=amineer@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -73 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 15 chunks +14 lines, -46 lines 0 comments Download
M Source/platform/mac/LocalCurrentGraphicsContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/mac/LocalCurrentGraphicsContext.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/platform/mac/ThemeMac.h View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/platform/mac/ThemeMac.mm View 9 chunks +37 lines, -19 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm View 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
amineer_google
6 years, 3 months ago (2014-09-03 17:43:56 UTC) #1
amineer_google
6 years, 3 months ago (2014-09-03 17:44:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r181331.

Powered by Google App Engine
This is Rietveld 408576698