Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 536973002: Revert 180822 "Specify clip rects when drawing Mac native widgets" (Closed)

Created:
6 years, 3 months ago by amineer_google
Modified:
6 years, 3 months ago
Reviewers:
ccameron
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Revert 180822 "Specify clip rects when drawing Mac native widgets" Speculatively reverting to address scrollbar dev blocker BUG=409708 Note there were some conflicts in the TestExpectations file, I did not try to resolve > Specify clip rects when drawing Mac native widgets > > Add the clip rect as an argument to LocalCurrentGraphicsContext, > and specify the rect for all callers. Add the rect argument for the one > direct caller to SkiaBitLocker (the argument will be made a requirement > once this lands). > > De-duplicate a bunch of rectangle-inflating code and move it into > ThemeMac. > > For the selected widgets that draw their own focus rings (most don't), > simply specify the maximum inflation of the clip rect as 16 pixels on > each side. This appears to be very generous. The correct API call to > compute this, focusRingMaskBoundsForFrame, was introduced in the > 10.7 API, and the widgets that draw their own focus rings wouldn't > need to do so if written against the the 10.7 API. > > BUG=247716 > > Review URL: https://codereview.chromium.org/488353003 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -81 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 15 chunks +46 lines, -14 lines 0 comments Download
M Source/platform/mac/LocalCurrentGraphicsContext.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/mac/LocalCurrentGraphicsContext.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/mac/ThemeMac.h View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/platform/mac/ThemeMac.mm View 9 chunks +19 lines, -37 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm View 2 chunks +1 line, -2 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
amineer_google
6 years, 3 months ago (2014-09-03 17:18:59 UTC) #1
amineer_google
6 years, 3 months ago (2014-09-03 17:19:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r181330.

Powered by Google App Engine
This is Rietveld 408576698