Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 528403002: Revert of Simplify IOSurface CoreAnimation code: Part 2 (Closed)

Created:
6 years, 3 months ago by aiolos (Not reviewing)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify IOSurface CoreAnimation code: Part 2 (patchset #13 id:240001 of https://codereview.chromium.org/490393002/) Reason for revert: crbug.com/410360 (Browser crashing on IOSurfaceLayer release in tab_switching.typical_25) Original issue's description: > Simplify IOSurface CoreAnimation code: Part 2 > > It isn't necessary to mess around with sharing CGLContextObjs anymore, > they were necessary only to share data between the frame subscriber > and the RenderWidgetHostViewMac. Just give each IOSurfaceLayer its > own CGLContextObj, and draw using immediate mode (using shaders > resulted in an increase in startup time). > > BUG=314190 > TBR=pfeldman@chromium.org > R=kbr@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/a83898264f64ad83bb98139e5e0dcb2c77db1997 TBR=kbr@chromium.org,ccameron@chromium.org NOTREECHECKS=true NOTRY=true BUG=314190 Committed: https://crrev.com/9cde44e2ac2ae2933ab67cbfef13bc75dfa16502 Cr-Commit-Position: refs/heads/master@{#293174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -329 lines) Patch
M content/browser/compositor/browser_compositor_view_private_mac.mm View 3 chunks +25 lines, -4 lines 0 comments Download
M content/browser/compositor/io_surface_layer_mac.h View 6 chunks +80 lines, -24 lines 0 comments Download
M content/browser/compositor/io_surface_layer_mac.mm View 5 chunks +199 lines, -298 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
aiolos (Not reviewing)
Created Revert of Simplify IOSurface CoreAnimation code: Part 2
6 years, 3 months ago (2014-09-03 17:12:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aiolos@chromium.org/528403002/1
6 years, 3 months ago (2014-09-03 17:14:00 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-03 17:14:02 UTC) #4
sullivan
lgtm
6 years, 3 months ago (2014-09-03 17:15:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aiolos@chromium.org/528403002/1
6 years, 3 months ago (2014-09-03 17:17:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as ce21597b7aa982e9f06202153fea6750053db7db
6 years, 3 months ago (2014-09-03 18:21:41 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:26:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cde44e2ac2ae2933ab67cbfef13bc75dfa16502
Cr-Commit-Position: refs/heads/master@{#293174}

Powered by Google App Engine
This is Rietveld 408576698