Uncouple ActiveScriptController from LocationBarController

Uncouple ActiveScriptController from LocationBarController

Since the indication of an active script running won't always be tied to the
location bar, it doesn't make sense for ActiveScriptController to be owned by
LocationBarController.

Since the "generated" actions were also only used for display
in the location bar, move that logic to the LocationBarController.

And, since we're there, also add a bit more testing for LocationBarController.

BUG=408676
TBR=avi@chromium.org (for method name change in cocoa)

Committed: https://crrev.com/91f162a14c5d8b4cb9ea8a8d3cd38e923e9fb2a3
Cr-Commit-Position: refs/heads/master@{#293153}

[Devlin, 2014-09-02 19:20:59]

Patchset #1 (id:20001) has been deleted

[Devlin, 2014-09-02 19:21:03]

Patchset #1 (id:40001) has been deleted

[Devlin, 2014-09-02 23:30:06]

Patchset #1 (id:60001) has been deleted

[Devlin, 2014-09-03 01:00:33]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2014-09-03 01:00:34]

Please take a look when you can. :)

[Finnur, 2014-09-03 09:30:06]

I don't have a problem with this; it is great that you are decoupling these
things and untangling the mess -- not to mention adding more test coverage. With
that, I'm willing to LGTM.

However, I'm also not an expert on active scripts, so you might get more
actionable feedback from someone who is (if I recall, Ben Kalman is), so perhaps
there's a possibility to clean more up. But, I'll leave that up to you.

https://codereview.chromium.org/527963003/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/location_bar_controller.h (right):

https://codereview.chromium.org/527963003/diff/80001/chrome/browser/extension...
chrome/browser/extensions/location_bar_controller.h:42: const Extension*
extension) OVERRIDE;
What? You don't like exnesions now? Is that it? :)

[Devlin, 2014-09-03 14:06:22]

On 2014/09/03 09:30:06, Finnur wrote:
> I don't have a problem with this; it is great that you are decoupling these
> things and untangling the mess -- not to mention adding more test coverage.
With
> that, I'm willing to LGTM.
> 
> However, I'm also not an expert on active scripts, so you might get more
> actionable feedback from someone who is (if I recall, Ben Kalman is), so
perhaps
> there's a possibility to clean more up. But, I'll leave that up to you.

The active script stuff is actually a project between Ben and myself, so
ActiveScriptController and related happens to be all code I wrote. :)  Normally,
it would go to Ben, but he's taking a well-deserved vacation for the next month,
and this next most closely relates to extension actions.

[Devlin, 2014-09-03 14:07:00]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2014-09-03 14:07:56]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-09-03 14:08:33]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/527963003/...

[Finnur, 2014-09-03 14:19:27]

Sounds good.

[commit-bot: I haz the power, 2014-09-03 15:56:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-09-03 16:49:37]

Committed patchset #1 (id:80001) as 3778d494d70cc6c4c656d459ec56aca7e6632e1f

[commit-bot: I haz the power, 2014-09-10 03:26:16]

Patchset 1 (id:??) landed as
https://crrev.com/91f162a14c5d8b4cb9ea8a8d3cd38e923e9fb2a3
Cr-Commit-Position: refs/heads/master@{#293153}