chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm - Issue 527963003: Uncouple ActiveScriptController from LocationBarController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

Issue 527963003: Uncouple ActiveScriptController from LocationBarController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

index cb5e3d5ccd57af04cd17cebbb09db6e5820e913a..cbf79326c1a80ada265080d3b35c6e4fcb5b2a6d 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

@@ -120,7 +120,7 @@ class AsyncUninstaller : public extensions::ExtensionUninstallDialog::Delegate {

browser_->tab_strip_model()->GetActiveWebContents();

if (activeTab &&

extensions::ActiveScriptController::GetForWebContents(activeTab)

- ->HasActiveScriptAction(extension_)) {

+ ->WantsToRun(extension_)) {

item = [menu addItemWithTitle:

l10n_util::GetNSStringWithFixup(IDS_EXTENSIONS_ALWAYS_RUN)

action:@selector(onAlwaysRun:)

« chrome/browser/extensions/location_bar_controller.h ('K') | « chrome/browser/extensions/tab_helper.cc ('k') | no next file » | no next file with comments »