Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: chrome/browser/extensions/active_script_controller.h

Issue 527963003: Uncouple ActiveScriptController from LocationBarController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/active_script_controller.h
diff --git a/chrome/browser/extensions/active_script_controller.h b/chrome/browser/extensions/active_script_controller.h
index d741c1efec92a53319f41aaa6a2d3c7a3aacc9a7..fe6f3cb4609025224a7427860bdb01fefed99b09 100644
--- a/chrome/browser/extensions/active_script_controller.h
+++ b/chrome/browser/extensions/active_script_controller.h
@@ -12,8 +12,7 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
-#include "base/memory/linked_ptr.h"
-#include "chrome/browser/extensions/location_bar_controller.h"
+#include "base/scoped_observer.h"
#include "content/public/browser/web_contents_observer.h"
#include "extensions/browser/extension_registry_observer.h"
#include "extensions/common/permissions/permissions_data.h"
@@ -64,12 +63,9 @@ class ActiveScriptController : public content::WebContentsObserver,
// been clicked, running any pending tasks that were previously shelved.
void OnClicked(const Extension* extension);
- // Returns true if there is an active script injection action for |extension|.
- bool HasActiveScriptAction(const Extension* extension);
-
- // Returns the action to display for the given |extension|, or NULL if no
- // action should be displayed.
- ExtensionAction* GetActionForExtension(const Extension* extension);
+ // Returns true if the given |extension| has a pending script that wants to
+ // run.
+ bool WantsToRun(const Extension* extension);
#if defined(UNIT_TEST)
// Only used in tests.
@@ -141,12 +137,6 @@ class ActiveScriptController : public content::WebContentsObserver,
// should incorporate more fully with ActiveTab.
std::set<std::string> permitted_extensions_;
- // Script badges that have been generated for extensions. This is both those
- // with actions already declared that are copied and normalised, and actions
- // that get generated for extensions that haven't declared anything.
- typedef std::map<std::string, linked_ptr<ExtensionAction> > ActiveScriptMap;
- ActiveScriptMap active_script_actions_;
-
ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
extension_registry_observer_;

Powered by Google App Engine
This is Rietveld 408576698