Make all_webkit depend on breakpad targets required to symbolize crashes

Make all_webkit depend on breakpad targets required to symbolize crashes

BUG=253351
R=dpranke@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232028

[Dirk Pranke, 2013-10-30 19:19:57]

lgtm

https://codereview.chromium.org/52713004/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/52713004/diff/1/build/all.gyp#newcode373
build/all.gyp:373: ['OS!="win"', {
Nit: I would probably flip this conditional, but it's not all that important ...

[jochen (gone - plz use gerrit), 2013-10-31 06:57:01]

Committed patchset #1 manually as r232028 (presubmit successful).

[Nico, 2013-11-27 01:06:29]

https://codereview.chromium.org/52713004/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/52713004/diff/1/build/all.gyp#newcode376
build/all.gyp:376: '../breakpad/breakpad.gyp:minidump_stackwalk',
This isn't correct. dump_syms only exists if OS is mac, ios, linux, or android.
minidump_stackwalk doesn't exist on ios.

As a result, this breaks tools/gyp-explain.py.

The best fix is probably to change breakpad.gyp to define these targets
unconditionally and make them type: none and empty on platforms where they don't
currently exist.

[jochen (gone - plz use gerrit), 2013-11-27 09:23:28]

https://codereview.chromium.org/52713004/diff/1/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/52713004/diff/1/build/all.gyp#newcode376
build/all.gyp:376: '../breakpad/breakpad.gyp:minidump_stackwalk',
On 2013/11/27 01:06:30, Nico wrote:
> This isn't correct. dump_syms only exists if OS is mac, ios, linux, or
android.
> minidump_stackwalk doesn't exist on ios.
> 
> As a result, this breaks tools/gyp-explain.py.
> 
> The best fix is probably to change breakpad.gyp to define these targets
> unconditionally and make them type: none and empty on platforms where they
don't
> currently exist. 

all_webkit is defined within a OS!="ios" block, so not sure what you mean?

[Nico, 2013-11-27 14:39:21]

Run tools/gyp-explain.py , follow its instructions. Something will fail
unless you remove these two lines.
On Nov 27, 2013 1:23 AM, <jochen@chromium.org> wrote:

>
> https://codereview.chromium.org/52713004/diff/1/build/all.gyp
> File build/all.gyp (right):
>
> https://codereview.chromium.org/52713004/diff/1/build/all.gyp#newcode376
> build/all.gyp:376: '../breakpad/breakpad.gyp:minidump_stackwalk',
> On 2013/11/27 01:06:30, Nico wrote:
>
>> This isn't correct. dump_syms only exists if OS is mac, ios, linux, or
>>
> android.
>
>> minidump_stackwalk doesn't exist on ios.
>>
>
>  As a result, this breaks tools/gyp-explain.py.
>>
>
>  The best fix is probably to change breakpad.gyp to define these
>>
> targets
>
>> unconditionally and make them type: none and empty on platforms where
>>
> they don't
>
>> currently exist.
>>
>
> all_webkit is defined within a OS!="ios" block, so not sure what you
> mean?
>
> https://codereview.chromium.org/52713004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.