Make all_webkit depend on breakpad targets required to symbolize crashes

build/all.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'All',
       'type': 'none',
       'xcode_create_dependents_test_runner': 1,
@@ skipping 351 matching lines @@
   'conditions': [
     ['OS!="ios"', {
       'targets': [
         {
           'target_name': 'all_webkit',
           'type': 'none',
           'dependencies': [
             '../third_party/WebKit/public/all.gyp:all_blink',
             '../content/content_shell_and_tests.gyp:content_shell',
           ],
+          'conditions': [
+            ['OS!="win"', {

[Dirk Pranke, 2013/10/30 19:19:57]

Nit: I would probably flip this conditional, but it's not all that important ...

+              'dependencies': [
+                '../breakpad/breakpad.gyp:dump_syms',
+                '../breakpad/breakpad.gyp:minidump_stackwalk',

[Nico, 2013/11/27 01:06:30]

This isn't correct. dump_syms only exists if OS is mac, ios, linux, or android.
minidump_stackwalk doesn't exist on ios.

As a result, this breaks tools/gyp-explain.py.

The best fix is probably to change breakpad.gyp to define these targets
unconditionally and make them type: none and empty on platforms where they don't
currently exist. 

[jochen (gone - plz use gerrit), 2013/11/27 09:23:28]

all_webkit is defined within a OS!="ios" block, so not sure what you mean?

+              ],
+            }, {  # OS=="win"
+              'dependencies': [
+                '../content/content_shell_and_tests.gyp:content_shell_crash_service',
+              ],
+            }],
+          ],
         }, # target_name: all_webkit
         {
           'target_name': 'chromium_builder_nacl_win_integration',
           'type': 'none',
           'dependencies': [
             'chromium_builder_qa', # needed for pyauto
             'chromium_builder_tests',
           ],
         }, # target_name: chromium_builder_nacl_win_integration
         {
@@ skipping 624 matching lines @@
             '../chrome/chrome.gyp:interactive_ui_tests_run',
             '../chrome/chrome.gyp:sync_integration_tests_run',
             '../chrome/chrome.gyp:unit_tests_run',
             '../net/net.gyp:net_unittests_run',
           ],
         }, # target_name: chromium_swarm_tests
       ],
     }],
   ], # conditions
 }