Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: build/all.gyp

Issue 52713004: Make all_webkit depend on breakpad targets required to symbolize crashes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/all_android.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/all.gyp
diff --git a/build/all.gyp b/build/all.gyp
index 43ac284e51a2853fabc941f8afc32a35bd75d430..dc997af289a677b0177f67d2ae182f7a031ad4fc 100644
--- a/build/all.gyp
+++ b/build/all.gyp
@@ -369,6 +369,18 @@
'../third_party/WebKit/public/all.gyp:all_blink',
'../content/content_shell_and_tests.gyp:content_shell',
],
+ 'conditions': [
+ ['OS!="win"', {
Dirk Pranke 2013/10/30 19:19:57 Nit: I would probably flip this conditional, but i
+ 'dependencies': [
+ '../breakpad/breakpad.gyp:dump_syms',
+ '../breakpad/breakpad.gyp:minidump_stackwalk',
Nico 2013/11/27 01:06:30 This isn't correct. dump_syms only exists if OS is
jochen (gone - plz use gerrit) 2013/11/27 09:23:28 all_webkit is defined within a OS!="ios" block, so
+ ],
+ }, { # OS=="win"
+ 'dependencies': [
+ '../content/content_shell_and_tests.gyp:content_shell_crash_service',
+ ],
+ }],
+ ],
}, # target_name: all_webkit
{
'target_name': 'chromium_builder_nacl_win_integration',
« no previous file with comments | « no previous file | build/all_android.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698