Issue 526073004: Canvas: composite video on canvas correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 526073004: Canvas: composite video on canvas correctly. (Closed)

Created:
6 years, 3 months ago by dshwang

Modified:
6 years, 3 months ago

Reviewers:

CC:
blink-reviews, jamesr, blink-reviews-html_chromium.org, philipj_slow, krit, jbroman, eric.carlson_apple.com, abarth-chromium, danakj, feature-media-reviews_chromium.org, dglazkov+blink, Rik, Stephen Chennney, aandrey+blink_chromium.org, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Canvas: composite video on canvas correctly. Currently, 2D Canvas composites a video as only source-over, because Blink doesn't pass composite information to chromium when calling platform video painting API. This CL fixes it. TEST=fast/canvas/canvas-drawImage-video.html BUG=407079 Review URL: https://codereview.chromium.org/443873005 git-svn-id: svn://svn.chromium.org/blink/trunk@181175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -3 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/canvas/canvas-drawImage-video.html	View	1 chunk	+45 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/canvas/canvas-drawImage-video-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/graphics/skia/SkiaUtils.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	public/platform/WebMediaPlayer.h	View	3 chunks	+2 lines, -2 lines	0 comments	Download