Source/core/html/HTMLVideoElement.cpp - Issue 526073004: Canvas: composite video on canvas correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLVideoElement.cpp

Issue 526073004: Canvas: composite video on canvas correctly. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/canvas-drawImage-video-expected.txt ('k') | Source/core/html/canvas/CanvasRenderingContext2D.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLVideoElement.cpp

diff --git a/Source/core/html/HTMLVideoElement.cpp b/Source/core/html/HTMLVideoElement.cpp

index 3c021ea423a6b0f8c9ca2b71f27710e8add1c307..cdb66c17230f7ca5f81402e057ad358c160b87e6 100644

--- a/Source/core/html/HTMLVideoElement.cpp

+++ b/Source/core/html/HTMLVideoElement.cpp

@@ -205,7 +205,8 @@ void HTMLVideoElement::paintCurrentFrameInContext(GraphicsContext* context, cons

return;

WebCanvas* canvas = context->canvas();

- webMediaPlayer()->paint(canvas, destRect, context->getNormalizedAlpha());

+ SkXfermode::Mode mode = WebCoreCompositeToSkiaComposite(context->compositeOperation(), context->blendModeOperation());

+ webMediaPlayer()->paint(canvas, destRect, context->getNormalizedAlpha(), mode);

}

bool HTMLVideoElement::copyVideoTextureToPlatformTexture(WebGraphicsContext3D* context, Platform3DObject texture, GLint level, GLenum internalFormat, GLenum type, bool premultiplyAlpha, bool flipY)