Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 524523003: Revert of Remove webkitConvertPointFromPageToNode() and webkitConvertPointFromNodeToPage() (Closed)

Created:
6 years, 3 months ago by philipj_slow
Modified:
6 years, 3 months ago
Reviewers:
eseidel
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Revert of Remove webkitConvertPointFromPageToNode() and webkitConvertPointFromNodeToPage() (patchset #1 of https://codereview.chromium.org/428533003/) Reason for revert: Wait for WebKitPoint use counter data and remove them together: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KS5GAM7JXtg/AXNh8otMw8MJ Original issue's description: > Remove webkitConvertPointFromPageToNode() and webkitConvertPointFromNodeToPage() > > Intent to Deprecate and Remove: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/KS5GAM7JXtg/7KyhsqQFZMkJ > > BUG=398352 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179135 BUG=398352

Patch Set 1 #

Patch Set 2 : leave those tests alone #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+908 lines, -3 lines) Patch
A LayoutTests/fast/dom/Window/webkitConvertPoint.html View 1 1 chunk +187 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Window/webkitConvertPoint-expected.txt View 1 1 chunk +200 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Window/webkitConvertPointUpdateLayout.html View 1 1 chunk +44 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/Window/webkitConvertPointUpdateLayout-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/platform/linux/fast/dom/Window/webkitConvertPoint-expected.txt View 1 1 chunk +200 lines, -0 lines 0 comments Download
A LayoutTests/platform/win-xp/fast/dom/Window/webkitConvertPoint-expected.txt View 1 1 chunk +200 lines, -0 lines 0 comments Download
M Source/core/dom/Node.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 1 chunk +28 lines, -0 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 2 2 chunks +31 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/Window.idl View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
Created Revert of Remove webkitConvertPointFromPageToNode() and webkitConvertPointFromNodeToPage()
6 years, 3 months ago (2014-08-29 09:30:16 UTC) #1
philipj_slow
rebase
6 years, 3 months ago (2014-08-29 11:57:33 UTC) #2
philipj_slow
philipj@opera.com changed reviewers: + eseidel@chromium.org - jochen@chromium.org
6 years, 3 months ago (2014-08-29 13:19:45 UTC) #3
philipj_slow
PTAL. No API owner chimed in on blink-dev, so I'm playing it safe.
6 years, 3 months ago (2014-08-29 13:19:45 UTC) #4
philipj_slow
6 years, 3 months ago (2014-08-29 19:49:57 UTC) #5
Please hold the review on this. Since you expressed a preference for removing
WebKitPoint on blink-dev and that's also what I'd prefer I'll sent an intent to
do just that.

Powered by Google App Engine
This is Rietveld 408576698