Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 52443006: Correct use of virtual and OVERRIDE in HTMLTrackElement (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
Reviewers:
Nate Chapin, eseidel
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Correct use of virtual and OVERRIDE in HTMLTrackElement canLoadUrl was virtual for no reason, and the TextTrackClient implementation was missing OVERRIDE. BUG=313287 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/html/HTMLTrackElement.h View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
7 years, 1 month ago (2013-10-30 22:48:49 UTC) #1
eseidel
Maybe it used to be part of TextTrackClient? https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/html/track/LoadableTextTrack.h&q=canLoadUrl&sq=package:chromium&type=cs&l=42
7 years, 1 month ago (2013-10-30 22:54:43 UTC) #2
Nate Chapin
lgtm
7 years, 1 month ago (2013-10-30 23:15:26 UTC) #3
philipj_slow
On 2013/10/30 22:54:43, eseidel wrote: > Maybe it used to be part of TextTrackClient? > ...
7 years, 1 month ago (2013-10-31 07:33:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/52443006/1
7 years, 1 month ago (2013-10-31 07:33:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=1449
7 years, 1 month ago (2013-10-31 09:42:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/52443006/1
7 years, 1 month ago (2013-10-31 09:59:58 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 10:39:57 UTC) #8
Message was sent while issue was closed.
Change committed as 161047

Powered by Google App Engine
This is Rietveld 408576698