Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: Source/core/html/HTMLTrackElement.h

Issue 52443006: Correct use of virtual and OVERRIDE in HTMLTrackElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE; 72 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
73 73
74 virtual void removedFrom(ContainerNode*) OVERRIDE; 74 virtual void removedFrom(ContainerNode*) OVERRIDE;
75 virtual bool isURLAttribute(const Attribute&) const OVERRIDE; 75 virtual bool isURLAttribute(const Attribute&) const OVERRIDE;
76 76
77 void loadTimerFired(Timer<HTMLTrackElement>*); 77 void loadTimerFired(Timer<HTMLTrackElement>*);
78 78
79 HTMLMediaElement* mediaElement() const; 79 HTMLMediaElement* mediaElement() const;
80 80
81 // TextTrackClient 81 // TextTrackClient
82 virtual void textTrackModeChanged(TextTrack*); 82 virtual void textTrackModeChanged(TextTrack*) OVERRIDE;
83 virtual void textTrackKindChanged(TextTrack*); 83 virtual void textTrackKindChanged(TextTrack*) OVERRIDE;
84 virtual void textTrackAddCues(TextTrack*, const TextTrackCueList*); 84 virtual void textTrackAddCues(TextTrack*, const TextTrackCueList*) OVERRIDE;
85 virtual void textTrackRemoveCues(TextTrack*, const TextTrackCueList*); 85 virtual void textTrackRemoveCues(TextTrack*, const TextTrackCueList*) OVERRI DE;
86 virtual void textTrackAddCue(TextTrack*, PassRefPtr<TextTrackCue>); 86 virtual void textTrackAddCue(TextTrack*, PassRefPtr<TextTrackCue>) OVERRIDE;
87 virtual void textTrackRemoveCue(TextTrack*, PassRefPtr<TextTrackCue>); 87 virtual void textTrackRemoveCue(TextTrack*, PassRefPtr<TextTrackCue>) OVERRI DE;
88 88
89 LoadableTextTrack* ensureTrack(); 89 LoadableTextTrack* ensureTrack();
90 virtual bool canLoadUrl(const KURL&); 90 bool canLoadUrl(const KURL&);
91 91
92 RefPtr<LoadableTextTrack> m_track; 92 RefPtr<LoadableTextTrack> m_track;
93 Timer<HTMLTrackElement> m_loadTimer; 93 Timer<HTMLTrackElement> m_loadTimer;
94 }; 94 };
95 95
96 DEFINE_NODE_TYPE_CASTS(HTMLTrackElement, hasTagName(HTMLNames::trackTag)); 96 DEFINE_NODE_TYPE_CASTS(HTMLTrackElement, hasTagName(HTMLNames::trackTag));
97 97
98 } 98 }
99 99
100 #endif 100 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698