Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: Source/core/html/HTMLTrackElement.h

Issue 52443006: Correct use of virtual and OVERRIDE in HTMLTrackElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTrackElement.h
diff --git a/Source/core/html/HTMLTrackElement.h b/Source/core/html/HTMLTrackElement.h
index ce0e1ba6bf24567992108223a7462241e0153697..942fd8b002054674ee8bd807d8214c4ce6f3193f 100644
--- a/Source/core/html/HTMLTrackElement.h
+++ b/Source/core/html/HTMLTrackElement.h
@@ -79,15 +79,15 @@ private:
HTMLMediaElement* mediaElement() const;
// TextTrackClient
- virtual void textTrackModeChanged(TextTrack*);
- virtual void textTrackKindChanged(TextTrack*);
- virtual void textTrackAddCues(TextTrack*, const TextTrackCueList*);
- virtual void textTrackRemoveCues(TextTrack*, const TextTrackCueList*);
- virtual void textTrackAddCue(TextTrack*, PassRefPtr<TextTrackCue>);
- virtual void textTrackRemoveCue(TextTrack*, PassRefPtr<TextTrackCue>);
+ virtual void textTrackModeChanged(TextTrack*) OVERRIDE;
+ virtual void textTrackKindChanged(TextTrack*) OVERRIDE;
+ virtual void textTrackAddCues(TextTrack*, const TextTrackCueList*) OVERRIDE;
+ virtual void textTrackRemoveCues(TextTrack*, const TextTrackCueList*) OVERRIDE;
+ virtual void textTrackAddCue(TextTrack*, PassRefPtr<TextTrackCue>) OVERRIDE;
+ virtual void textTrackRemoveCue(TextTrack*, PassRefPtr<TextTrackCue>) OVERRIDE;
LoadableTextTrack* ensureTrack();
- virtual bool canLoadUrl(const KURL&);
+ bool canLoadUrl(const KURL&);
RefPtr<LoadableTextTrack> m_track;
Timer<HTMLTrackElement> m_loadTimer;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698