mac: Remove simplified fullscreen.

mac: Remove simplified fullscreen.

It was an experimental feature that is no longer being actively developed.

BUG=NONE

Committed: https://crrev.com/8a5b0eec9925bae52b26905593c29fed5c6a0abc
Cr-Commit-Position: refs/heads/master@{#293815}

[erikchen, 2014-08-29 23:20:10]

erikchen@chromium.org changed reviewers:
+ rsesek@chromium.org

[erikchen, 2014-08-29 23:20:10]

rsesek: Please review.

[erikchen, 2014-08-29 23:28:20]

btw, given that after the refactor, there's almost no logic/maintenance left in
simplified fullscreen, why are we removing it? Presumably a small but vocal
subset of Chrome users still like it...

[rohitrao (ping after 24h), 2014-08-29 23:30:37]

On 2014/08/29 23:28:20, erikchen wrote:
> btw, given that after the refactor, there's almost no logic/maintenance left
in
> simplified fullscreen, why are we removing it? Presumably a small but vocal
> subset of Chrome users still like it...

In theory, the fullscreen mode we're building now is what simplified fullscreen
was intended to be: one unified appkit fullscreen UI, with a separate window for
HTML5 and plugins.

[Robert Sesek, 2014-09-02 14:19:33]

LGTM

On 2014/08/29 23:28:20, erikchen wrote:
> btw, given that after the refactor, there's almost no logic/maintenance left
in
> simplified fullscreen, why are we removing it? Presumably a small but vocal
> subset of Chrome users still like it...

We don't keep features around in about:flags if they aren't going to eventually
make it into the final product. Feature flags are used for experiments, and this
one has ran its course and we're not moving forward with it.

https://codereview.chromium.org/523233002/diff/1/chrome/browser/ui/cocoa/brow...
File chrome/browser/ui/cocoa/browser_window_controller.h (right):

https://codereview.chromium.org/523233002/diff/1/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser_window_controller.h:503: // Tries to use AppKit
Fullscreen, falls back to Immersive Fullscreen.
I think we'll want to make this always use immersive in the future.

[erikchen, 2014-09-04 17:29:34]

erikchen@chromium.org changed reviewers:
+ pkasting@chromium.org

[erikchen, 2014-09-04 17:29:35]

pkasting: Looking for an OWNER review of chrome/browser/ui/*

[Peter Kasting, 2014-09-08 17:48:59]

On 2014/09/04 17:29:35, erikchen wrote:
> pkasting: Looking for an OWNER review of chrome/browser/ui/*

I don't speak ObjC, so I can't review the cocoa/ code.

The other two files in c/b/ui/ LGTM.

[erikchen, 2014-09-08 18:00:46]

cocoa code was reviewed by rsesek. Proceeding to land CL.

[erikchen, 2014-09-08 18:00:49]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-09-08 18:02:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/523233002/20001

[commit-bot: I haz the power, 2014-09-08 23:50:25]

Committed patchset #2 (id:20001) as 185e930835305e0165cf1dee72395220ca5ed073

[commit-bot: I haz the power, 2014-09-10 03:49:04]

Patchset 2 (id:??) landed as
https://crrev.com/8a5b0eec9925bae52b26905593c29fed5c6a0abc
Cr-Commit-Position: refs/heads/master@{#293815}