Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3215)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 523233002: mac: Remove simplified fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_fullscreen2
Patch Set: Rebase against top of tree. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index aff989b80de903db37432800a806beb4eef00a38..8c8bc1f579be768abb756c92c365b5c1a55b2d69 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -202,18 +202,6 @@ willPositionSheet:(NSWindow*)sheet
switch (presentationModeController_.get().slidingStyle) {
case fullscreen_mac::OMNIBOX_TABS_PRESENT:
break;
- case fullscreen_mac::OMNIBOX_PRESENT: {
- // At rest: omnibox showing. yOffset should be tabstrip height
- // When cursor is at top: everything shows. yOffset should be -menubar
- // height.
- CGFloat tabStripHeight = 0;
- if ([self hasTabStrip])
- tabStripHeight = NSHeight([[self tabStripView] frame]);
- yOffset +=
- std::floor((1 - presentationModeController_.get().toolbarFraction) *
- tabStripHeight);
- break;
- }
case fullscreen_mac::OMNIBOX_TABS_HIDDEN:
// In presentation mode, |yOffset| accounts for the sliding position of
// the floating bar and the extra offset needed to dodge the menu bar.
@@ -264,9 +252,7 @@ willPositionSheet:(NSWindow*)sheet
if ([self isInFullscreenWithOmniboxSliding]) {
switch (presentationModeController_.get().slidingStyle) {
case fullscreen_mac::OMNIBOX_TABS_PRESENT:
- case fullscreen_mac::OMNIBOX_PRESENT:
- // Do nothing in Canonical Fullscreen and Simplified Fullscreen. All
- // content slides.
+ // Do nothing in Canonical Fullscreen. All content slides.
break;
case fullscreen_mac::OMNIBOX_TABS_HIDDEN:
// If in presentation mode, reset |maxY| to top of screen, so that the
@@ -762,14 +748,7 @@ willPositionSheet:(NSWindow*)sheet
regularWindow:[self window]
fullscreenWindow:fullscreenWindow_.get()];
- // When simplified fullscreen is enabled, do not enter presentation mode.
- const CommandLine* command_line = CommandLine::ForCurrentProcess();
- fullscreen_mac::SlidingStyle style;
- if (command_line->HasSwitch(switches::kEnableSimplifiedFullscreen)) {
- style = fullscreen_mac::OMNIBOX_PRESENT;
- } else {
- style = fullscreen_mac::OMNIBOX_TABS_HIDDEN;
- }
+ fullscreen_mac::SlidingStyle style = fullscreen_mac::OMNIBOX_TABS_HIDDEN;
[self adjustUIForSlidingFullscreenStyle:style];
// AppKit is helpful and prevents NSWindows from having the same height as
@@ -811,13 +790,6 @@ willPositionSheet:(NSWindow*)sheet
kCGDisplayBlendSolidColor, 0.0, 0.0, 0.0, /*synchronous=*/true);
}
- // When simplified fullscreen is enabled, the menubar status is managed
- // directly by BWC.
- const CommandLine* command_line = CommandLine::ForCurrentProcess();
- if (command_line->HasSwitch(switches::kEnableSimplifiedFullscreen)) {
- // TODO(rohitrao): Add code to manage the menubar here.
- }
-
[self windowWillExitFullScreen:nil];
[self moveViewsForImmersiveFullscreen:NO
@@ -914,14 +886,9 @@ willPositionSheet:(NSWindow*)sheet
browser_->fullscreen_controller()->IsWindowFullscreenForTabOrPending();
enteringAppKitFullscreen_ = YES;
- fullscreen_mac::SlidingStyle style;
- const CommandLine* command_line = CommandLine::ForCurrentProcess();
- if (command_line->HasSwitch(switches::kEnableSimplifiedFullscreen))
- style = fullscreen_mac::OMNIBOX_PRESENT;
- else if (mode)
- style = fullscreen_mac::OMNIBOX_TABS_HIDDEN;
- else
- style = fullscreen_mac::OMNIBOX_TABS_PRESENT;
+ fullscreen_mac::SlidingStyle style =
+ mode ? fullscreen_mac::OMNIBOX_TABS_HIDDEN
+ : fullscreen_mac::OMNIBOX_TABS_PRESENT;
[self adjustUIForSlidingFullscreenStyle:style];
}
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/presentation_mode_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698