Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.h

Issue 523233002: mac: Remove simplified fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_fullscreen2
Patch Set: Rebase against top of tree. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.h
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.h b/chrome/browser/ui/cocoa/browser_window_controller.h
index 5457874ade7a2b92c9b3907ae6f7bf28334c99e3..6320eda13ff715bdd3c5baa894e8540e446a968e 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.h
+++ b/chrome/browser/ui/cocoa/browser_window_controller.h
@@ -423,12 +423,10 @@ class Command;
// invoked causes all fullscreen modes to exit.
//
// ----------------------------------------------------------------------------
-// There are 3 "styles" of omnibox sliding.
+// There are 2 "styles" of omnibox sliding.
// + OMNIBOX_TABS_PRESENT: Both the omnibox and the tabstrip are present.
// Moving the cursor to the top causes the menubar to appear, and everything
// else to slide down.
-// + OMNIBOX_PRESENT: The tabstrip is hidden. Moving the cursor to the top
-// shows the tabstrip and menubar, sliding everything else down.
// + OMNIBOX_TABS_HIDDEN: Both tabstrip and omnibox are hidden. Moving cursor
// to top shows tabstrip, omnibox, and menu bar.
//
@@ -462,11 +460,6 @@ class Command;
//
// + HTML5 fullscreen. <-- Currently uses AppKitFullscreen API. This should
// eventually migrate to the Immersive Fullscreen API.
-//
-// TODO(erikchen): Remove this.
-// + Simplified fullscreen. Hidden by default. Some users have manually
-// enabled it.
-// - OMNIBOX_PRESENT. Can be with either fullscreen API.
// Methods having to do with fullscreen and presentation mode.
@interface BrowserWindowController(Fullscreen)
@@ -502,7 +495,7 @@ class Command;
- (void)enterPresentationModeForURL:(const GURL&)url
bubbleType:(FullscreenExitBubbleType)bubbleType;
-// Tries to enter presentation mode. Falls back to simplified fullscreen.
+// Tries to use AppKit Fullscreen, falls back to Immersive Fullscreen.
- (void)enterHTML5FullscreenForURL:(const GURL&)url
bubbleType:(FullscreenExitBubbleType)bubbleType;
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698